You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/04/12 17:51:00 UTC
Review Request 46100: Support option to not create a version
definition resource but return the structured JSON only
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46100/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
Bugs: AMBARI-15837
https://issues.apache.org/jira/browse/AMBARI-15837
Repository: ambari
Description
-------
Adds a dry_run option to creation of VDF and return the same response as a GET. This is different from the rest of our API since part of the response comes from subresources. Subresources are only asked on GET, but there is no entity to reference in this case, so the POST/dry_run=true must contain all of it without writing to the DB.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java ba4491e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 963265b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 5a63606
Diff: https://reviews.apache.org/r/46100/diff/
Testing
-------
Manual. Automated in progress.
Thanks,
Nate Cole
Re: Review Request 46100: Support option to not create a version
definition resource but return the structured JSON only
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46100/#review128489
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 12, 2016, 4:55 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46100/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 4:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
>
>
> Bugs: AMBARI-15837
> https://issues.apache.org/jira/browse/AMBARI-15837
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds a dry_run option to creation of VDF and return the same response as a GET. This is different from the rest of our API since part of the response comes from subresources. Subresources are only asked on GET, but there is no entity to reference in this case, so the POST/dry_run=true must contain all of it without writing to the DB.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java ba4491e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 963265b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 5a63606
>
> Diff: https://reviews.apache.org/r/46100/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> (Test in error is invalid cert against https://hortonworks.com and unrelated to this patch)
>
> Results :
>
> Tests in error:
> AmbariManagementControllerTest.testUpdateRepoUrlController:8524 » IllegalArgument
>
> Tests run: 4134, Failures: 0, Errors: 1, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:44.990s
> [INFO] Finished at: Tue Apr 12 12:07:01 EDT 2016
> [INFO] Final Memory: 36M/670M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 46100: Support option to not create a version
definition resource but return the structured JSON only
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 12, 2016, 2:37 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java, lines 199-204
> > <https://reviews.apache.org/r/46100/diff/1/?file=1341528#file1341528line199>
> >
> > Get rid of the else; set it to false initially - looks cleaner.
Will do.
> On April 12, 2016, 2:37 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java, line 102
> > <https://reviews.apache.org/r/46100/diff/1/?file=1341528#file1341528line102>
> >
> > Should we extract this to a higher level to try to convery a sense of "dry runness" to the other providers as well? I can see it being useful in other areas as well.
Future.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46100/#review128497
-----------------------------------------------------------
On April 12, 2016, 12:55 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46100/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 12:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
>
>
> Bugs: AMBARI-15837
> https://issues.apache.org/jira/browse/AMBARI-15837
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds a dry_run option to creation of VDF and return the same response as a GET. This is different from the rest of our API since part of the response comes from subresources. Subresources are only asked on GET, but there is no entity to reference in this case, so the POST/dry_run=true must contain all of it without writing to the DB.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java ba4491e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 963265b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 5a63606
>
> Diff: https://reviews.apache.org/r/46100/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> (Test in error is invalid cert against https://hortonworks.com and unrelated to this patch)
>
> Results :
>
> Tests in error:
> AmbariManagementControllerTest.testUpdateRepoUrlController:8524 » IllegalArgument
>
> Tests run: 4134, Failures: 0, Errors: 1, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:44.990s
> [INFO] Finished at: Tue Apr 12 12:07:01 EDT 2016
> [INFO] Final Memory: 36M/670M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 46100: Support option to not create a version
definition resource but return the structured JSON only
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46100/#review128497
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java (line 102)
<https://reviews.apache.org/r/46100/#comment191906>
Should we extract this to a higher level to try to convery a sense of "dry runness" to the other providers as well? I can see it being useful in other areas as well.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java (lines 197 - 202)
<https://reviews.apache.org/r/46100/#comment191907>
Get rid of the else; set it to false initially - looks cleaner.
- Jonathan Hurley
On April 12, 2016, 12:55 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46100/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 12:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
>
>
> Bugs: AMBARI-15837
> https://issues.apache.org/jira/browse/AMBARI-15837
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds a dry_run option to creation of VDF and return the same response as a GET. This is different from the rest of our API since part of the response comes from subresources. Subresources are only asked on GET, but there is no entity to reference in this case, so the POST/dry_run=true must contain all of it without writing to the DB.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java ba4491e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 963265b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 5a63606
>
> Diff: https://reviews.apache.org/r/46100/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> (Test in error is invalid cert against https://hortonworks.com and unrelated to this patch)
>
> Results :
>
> Tests in error:
> AmbariManagementControllerTest.testUpdateRepoUrlController:8524 » IllegalArgument
>
> Tests run: 4134, Failures: 0, Errors: 1, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:44.990s
> [INFO] Finished at: Tue Apr 12 12:07:01 EDT 2016
> [INFO] Final Memory: 36M/670M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 46100: Support option to not create a version
definition resource but return the structured JSON only
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46100/
-----------------------------------------------------------
(Updated April 12, 2016, 12:55 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya.
Bugs: AMBARI-15837
https://issues.apache.org/jira/browse/AMBARI-15837
Repository: ambari
Description
-------
Adds a dry_run option to creation of VDF and return the same response as a GET. This is different from the rest of our API since part of the response comes from subresources. Subresources are only asked on GET, but there is no entity to reference in this case, so the POST/dry_run=true must contain all of it without writing to the DB.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java ba4491e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 963265b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 5a63606
Diff: https://reviews.apache.org/r/46100/diff/
Testing (updated)
-------
Manual. Automated:
(Test in error is invalid cert against https://hortonworks.com and unrelated to this patch)
Results :
Tests in error:
AmbariManagementControllerTest.testUpdateRepoUrlController:8524 » IllegalArgument
Tests run: 4134, Failures: 0, Errors: 1, Skipped: 32
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:44.990s
[INFO] Finished at: Tue Apr 12 12:07:01 EDT 2016
[INFO] Final Memory: 36M/670M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole