[GitHub] [spark] HyukjinKwon commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338443245
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
 ##########
 @@ -147,14 +147,7 @@ class JDBCOptions(
      """.stripMargin
   )
 
-  val fetchSize = {
-    val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt
-    require(size >= 0,
 
 Review comment:
   Actually, we could just remove this condition and set it as is, and then expect the DBMS to throw an error as well. Seems like Postgres throws an error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org