svn commit: r560220 - in /myfaces/core/trunk/api/src/main/java/javax/faces/component: UIInput.java _ComponentUtils.java

[mm...@apache.org]

Author: mmarinschek
Date: Fri Jul 27 05:58:20 2007
New Revision: 560220

URL: http://svn.apache.org/viewvc?view=rev&rev=560220
Log:
https://issues.apache.org/jira/browse/MYFACES-1687: updateModel throws an exception, and doesn't show a message to the user anymore.

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
    myfaces/core/trunk/api/src/main/java/javax/faces/component/_ComponentUtils.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diff&rev=560220&r1=560219&r2=560220
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java Fri Jul 27 05:58:20 2007
@@ -31,6 +31,7 @@
 import javax.faces.event.ValueChangeListener;
 import javax.faces.render.Renderer;
 import javax.faces.validator.Validator;
+import javax.faces.FacesException;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -277,27 +278,9 @@
             setValue(null);
             setLocalValueSet(false);
         }
-        catch (EvaluationException ee)
+        catch (Exception ex)
         {
-            String exceptionMessage = ee.getMessage();
-            if (exceptionMessage == null)
-            {
-                _MessageUtils.addErrorMessage(context, this,
-                        CONVERSION_MESSAGE_ID, new Object[] { getId() });
-            }
-            else
-            {
-                _MessageUtils.addErrorMessage(context, this, ee);
-            }
-            
-            setValid(false);
-        }
-        catch (RuntimeException e)
-        {
-        	//Object[] args = {getId()};
-            context.getExternalContext().log(e.getMessage(), e);
-            _MessageUtils.addErrorMessage(context, this,CONVERSION_MESSAGE_ID,new Object[]{getId()});
-            setValid(false);
+            throw new FacesException("Exception while setting value : "+vb.getExpressionString()+"of component with path : "+_ComponentUtils.getPathToComponent(this),ex);
         }
     }
 

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/_ComponentUtils.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/_ComponentUtils.java?view=diff&rev=560220&r1=560219&r2=560220
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/_ComponentUtils.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/_ComponentUtils.java Fri Jul 27 05:58:20 2007
@@ -100,5 +100,49 @@
         return value.toString();
     }
 
+    static String getPathToComponent(UIComponent component) {
+        StringBuffer buf = new StringBuffer();
+
+        if(component == null)
+        {
+            buf.append("{Component-Path : ");
+            buf.append("[null]}");
+            return buf.toString();
+        }
+
+        getPathToComponent(component,buf);
+
+        buf.insert(0,"{Component-Path : ");
+        buf.append("}");
+
+        return buf.toString();
+    }
+
+    private static void getPathToComponent(UIComponent component, StringBuffer buf)
+    {
+        if(component == null)
+            return;
+
+        StringBuffer intBuf = new StringBuffer();
+
+        intBuf.append("[Class: ");
+        intBuf.append(component.getClass().getName());
+        if(component instanceof UIViewRoot)
+        {
+            intBuf.append(",ViewId: ");
+            intBuf.append(((UIViewRoot) component).getViewId());
+        }
+        else
+        {
+            intBuf.append(",Id: ");
+            intBuf.append(component.getId());
+        }
+        intBuf.append("]");
+
+        buf.insert(0,intBuf.toString());
+
+        getPathToComponent(component.getParent(), buf);
+    }
+
 
 }