[GitHub] [tvm] nverke commented on a diff in pull request #13721: [MetaSchedule][Hexagon] Add MultiLevelTilingHexagon to schedule asyn…

["nverke (via GitHub)" <gi...@apache.org>]

nverke commented on code in PR #13721:
URL: https://github.com/apache/tvm/pull/13721#discussion_r1110167539


##########
python/tvm/tir/tensor_intrin/hexagon.py:
##########
@@ -68,12 +69,12 @@ def sync_dma_load_impl(a: T.handle, c: T.handle) -> None:
     return sync_dma_load_desc, sync_dma_load_impl
 
 
-def generate_dot_product_32x4_u8u8i32(mem_scope="global"):
+def generate_dot_product_32x4_u8u8i32(read_mem_scope="global", write_mem_scope="global"):

Review Comment:
   Because typically these are used without vtcm 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org