[GitHub] [systemds] corepointer commented on pull request #1317: [SYSTEMDS-3020] Initial GPU junit tests

[GitBox <gi...@apache.org>]

corepointer commented on pull request #1317:
URL: https://github.com/apache/systemds/pull/1317#issuecomment-860714047


   >     1. Is this setup allows writing feature tests on gpu, where the baseline is also with `-gpu` (e.g. compare `-gpu -lineage` with `-gpu`)?
   
   All tests add -gpu. It is up to your test to add more. So -lineage -gpu is definitely possible.
   
   >     2. I think this is an easy enough way to run regression tests in a gpu. But effect-wise, how is it different from adding `-gpu` to the existing test classes?
   
   At the moment it is no different (other than the test checking for the appearance of the corresponding gpu instruction in the heavy hitter output). The content of new tests is up to its author - anything's possible ;-)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org