You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Karl Wettin (JIRA)" <ji...@apache.org> on 2008/04/10 02:50:04 UTC
[jira] Created: (MAHOUT-33) Matrix tests share code that can be
placed in an abstract class
Matrix tests share code that can be placed in an abstract class
---------------------------------------------------------------
Key: MAHOUT-33
URL: https://issues.apache.org/jira/browse/MAHOUT-33
Project: Mahout
Issue Type: Improvement
Reporter: Karl Wettin
Assignee: Karl Wettin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (MAHOUT-33) Matrix tests share code that can
be placed in an abstract class
Posted by Jeff Eastman <je...@windwardsolutions.com>.
Karl Wettin (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Karl Wettin updated MAHOUT-33:
> ------------------------------
>
> Attachment: MAHOUT-33.patch
>
> This was spawned by MAHOUT-26 and by mistake this patch also contains the contents of that patch. I did not mean to do that, but there you go. I'm ready to commit that too.
>
> I did not check everything with my eyes, it was too much but everything pass though.
>
>
>
>
>
>> Matrix tests share code that can be placed in an abstract class
>> ---------------------------------------------------------------
>>
>> Key: MAHOUT-33
>> URL: https://issues.apache.org/jira/browse/MAHOUT-33
>> Project: Mahout
>> Issue Type: Improvement
>> Reporter: Karl Wettin
>> Assignee: Karl Wettin
>> Attachments: MAHOUT-33.patch
>>
>>
>>
>
>
>
-1 It occurred to me as I was copying and pasting the unit tests that
many of the methods could indeed be refactored. Unfortunately, you must
have forgotten to svn add the new MatrixTest superclass before you
diffed <grin>. I do that all the time myself.
[jira] Updated: (MAHOUT-33) Matrix tests share code that can be
placed in an abstract class
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated MAHOUT-33:
------------------------------
Attachment: MAHOUT-33.patch
This was spawned by MAHOUT-26 and by mistake this patch also contains the contents of that patch. I did not mean to do that, but there you go. I'm ready to commit that too.
I did not check everything with my eyes, it was too much but everything pass though.
> Matrix tests share code that can be placed in an abstract class
> ---------------------------------------------------------------
>
> Key: MAHOUT-33
> URL: https://issues.apache.org/jira/browse/MAHOUT-33
> Project: Mahout
> Issue Type: Improvement
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Attachments: MAHOUT-33.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (MAHOUT-33) Matrix tests share code that can be
placed in an abstract class
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin closed MAHOUT-33.
-----------------------------
> Matrix tests share code that can be placed in an abstract class
> ---------------------------------------------------------------
>
> Key: MAHOUT-33
> URL: https://issues.apache.org/jira/browse/MAHOUT-33
> Project: Mahout
> Issue Type: Improvement
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Attachments: MAHOUT-33.patch, MAHOUT-33.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (MAHOUT-33) Matrix tests share code that can
be placed in an abstract class
Posted by Jeff Eastman <je...@windwardsolutions.com>.
Karl Wettin (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Karl Wettin updated MAHOUT-33:
> ------------------------------
>
> Attachment: MAHOUT-33.patch
>
> Now with MatrixTest.java : )
>
> Still tainted with MAHOUT-26
>
>
>> Matrix tests share code that can be placed in an abstract class
>> ---------------------------------------------------------------
>>
>> Key: MAHOUT-33
>> URL: https://issues.apache.org/jira/browse/MAHOUT-33
>> Project: Mahout
>> Issue Type: Improvement
>> Reporter: Karl Wettin
>> Assignee: Karl Wettin
>> Attachments: MAHOUT-33.patch, MAHOUT-33.patch
>>
>>
>>
>
>
>
+1 Nice improvement Karl. Patch installed cleanly and all unit tests
run. Green board.
Jeff
[jira] Updated: (MAHOUT-33) Matrix tests share code that can be
placed in an abstract class
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated MAHOUT-33:
------------------------------
Attachment: MAHOUT-33.patch
Now with MatrixTest.java : )
Still tainted with MAHOUT-26
> Matrix tests share code that can be placed in an abstract class
> ---------------------------------------------------------------
>
> Key: MAHOUT-33
> URL: https://issues.apache.org/jira/browse/MAHOUT-33
> Project: Mahout
> Issue Type: Improvement
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Attachments: MAHOUT-33.patch, MAHOUT-33.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAHOUT-33) Matrix tests share code that can be
placed in an abstract class
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin resolved MAHOUT-33.
-------------------------------
Resolution: Fixed
Committed in rev 647170 without beeing tainted with Laplace transform. see MAHOUT-26 for that.
> Matrix tests share code that can be placed in an abstract class
> ---------------------------------------------------------------
>
> Key: MAHOUT-33
> URL: https://issues.apache.org/jira/browse/MAHOUT-33
> Project: Mahout
> Issue Type: Improvement
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Attachments: MAHOUT-33.patch, MAHOUT-33.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-33) Matrix tests share code that can be
placed in an abstract class
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated MAHOUT-33:
------------------------------
Fix Version/s: 0.1
> Matrix tests share code that can be placed in an abstract class
> ---------------------------------------------------------------
>
> Key: MAHOUT-33
> URL: https://issues.apache.org/jira/browse/MAHOUT-33
> Project: Mahout
> Issue Type: Improvement
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Fix For: 0.1
>
> Attachments: MAHOUT-33.patch, MAHOUT-33.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.