[jira] Commented: (CXF-1137) CXF wsdl2java NPE's if it cannot find the wsdl:portType identified by a wsdl:binding

["maomaode (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537800 ] 

maomaode commented on CXF-1137:
-------------------------------

Well, the exception actually is from the WSDLServiceBuilder.java in the rt/core,  

If you turn on the -validation, tools do give you the error msg, but by default we turn off the validation during wsdl definition build, 
There's couple rules opened by default during the wsdl service build.

I guess to fix this issue, the best option is turn on the validation by default, and fix all the wrong wsdls in the cxf tests, but it's a big task

> CXF wsdl2java NPE's if it cannot find the wsdl:portType identified by a wsdl:binding
> ------------------------------------------------------------------------------------
>
>                 Key: CXF-1137
>                 URL: https://issues.apache.org/jira/browse/CXF-1137
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.0.2
>            Reporter: Glen Mazza
>            Assignee: maomaode
>         Attachments: helloWorld.wsdl
>
>
> If a user accidentally gives a wrong portType name in the wsdl:binding section, wsdl2java returns a NullPointerException without giving the user any feedback why.  For example, for this portType:
>    <wsdl:portType name="HelloWorldPortType">
>              .....
>    </wsdl:portType>
> The name should be tns:HelloWorldPortType in the binding:
>    <wsdl:binding name="HelloWorldSoapBinding" type="tns:HelloWorldPortType">
>              .....
>    </wsdl:binding>
> But if the user accidentally has this in the WSDL:
>    <wsdl:binding name="HelloWorldSoapBinding" type="tns:HelloWorld">  (wrong type given)
>              .....
>    </wsdl:binding>
> wsdl2java will return an NPE without any feedback about what the problem is.
> GlassFish Metro correctly returns a user-friendly error message under these circumstances:
> wsdl:portType "{http://company.hw.demo/}HelloWorld" not found in the wsdl: file:/blah/blah/blah/helloWorld.wsdl

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.