You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/04/15 00:21:33 UTC
Review Request 58465: Fixed alicloud unit test for limited timeout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58465/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, Jie Yu, Joseph Wu, and Vinod Kone.
Repository: mesos
Description
-------
Alicloud server is in Asia. We parameterized the unit test
`ROOT_INTERNET_CURL_SimpleCommand` to test different registry with
unifed containerizer. Longer `executor_registration_timeout` should
be given to make sure the image download is not impacted by network
legacy.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
Diff: https://reviews.apache.org/r/58465/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 58465: Fixed alicloud unit test for limited
timeout.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58465/#review172151
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On April 17, 2017, 4:37 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58465/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 4:37 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, Jie Yu, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Alicloud server is in Asia. We parameterized the unit test
> `ROOT_INTERNET_CURL_SimpleCommand` to test different registry with
> unifed containerizer. Longer `executor_registration_timeout` should
> be given to make sure the image download is not impacted by network
> legacy.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
>
>
> Diff: https://reviews.apache.org/r/58465/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 58465: Fixed alicloud unit test for limited
timeout.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58465/
-----------------------------------------------------------
(Updated April 17, 2017, 9:37 a.m.)
Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, Jie Yu, Joseph Wu, and Vinod Kone.
Repository: mesos
Description
-------
Alicloud server is in Asia. We parameterized the unit test
`ROOT_INTERNET_CURL_SimpleCommand` to test different registry with
unifed containerizer. Longer `executor_registration_timeout` should
be given to make sure the image download is not impacted by network
legacy.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
Diff: https://reviews.apache.org/r/58465/diff/2/
Changes: https://reviews.apache.org/r/58465/diff/1-2/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 58465: Fixed alicloud unit test for limited
timeout.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58465/#review172074
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/provisioner_docker_tests.cpp
Line 530 (original), 535 (patched)
<https://reviews.apache.org/r/58465/#comment245154>
Can you use Minutes(3) here?
- Jie Yu
On April 15, 2017, 12:21 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58465/
> -----------------------------------------------------------
>
> (Updated April 15, 2017, 12:21 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, Jie Yu, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Alicloud server is in Asia. We parameterized the unit test
> `ROOT_INTERNET_CURL_SimpleCommand` to test different registry with
> unifed containerizer. Longer `executor_registration_timeout` should
> be given to make sure the image download is not impacted by network
> legacy.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
>
>
> Diff: https://reviews.apache.org/r/58465/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 58465: Fixed alicloud unit test for limited
timeout.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58465/#review172048
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58465]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 15, 2017, 12:21 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58465/
> -----------------------------------------------------------
>
> (Updated April 15, 2017, 12:21 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, Jie Yu, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Alicloud server is in Asia. We parameterized the unit test
> `ROOT_INTERNET_CURL_SimpleCommand` to test different registry with
> unifed containerizer. Longer `executor_registration_timeout` should
> be given to make sure the image download is not impacted by network
> legacy.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
>
>
> Diff: https://reviews.apache.org/r/58465/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>