You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "stillya (via GitHub)" <gi...@apache.org> on 2023/06/09 16:00:01 UTC
[GitHub] [kafka] stillya opened a new pull request, #13836: KAFKA-14218: Replace temp file handler with JUnit 5 Temporary Directory Support
stillya opened a new pull request, #13836:
URL: https://github.com/apache/kafka/pull/13836
### Description
We created many temp files in tests, and sometimes we forgot to delete them after usage. Instead of polluting @AfterEach for each test, we should consider to use JUnit 5 TempDirectory Extension. I have replaced it almost everywhere(if didn't miss something), except places where it's not appropriate to do so and JUnit 4 is still being used.
### Testing
`./gradlew integrationTes`t and `./gradlew unitTest` is successful locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13836: KAFKA-14218: Replace temp file handler with JUnit 5 Temporary Directory Support
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13836:
URL: https://github.com/apache/kafka/pull/13836#issuecomment-1711026816
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org