svn commit: r1090828 - /commons/proper/lang/trunk/findbugs-exclude-filter.xml

[lu...@apache.org]

Author: luc
Date: Sun Apr 10 16:53:39 2011
New Revision: 1090828

URL: http://svn.apache.org/viewvc?rev=1090828&view=rev
Log:
filtered out false positive findbugs warnings

Modified:
    commons/proper/lang/trunk/findbugs-exclude-filter.xml

Modified: commons/proper/lang/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/findbugs-exclude-filter.xml?rev=1090828&r1=1090827&r2=1090828&view=diff
==============================================================================
--- commons/proper/lang/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/lang/trunk/findbugs-exclude-filter.xml Sun Apr 10 16:53:39 2011
@@ -26,9 +26,34 @@
   <!-- Reason: Optimization to use == -->
   <Match>
     <Class name="org.apache.commons.lang3.BooleanUtils" />
-    <Method name="toBoolean" />
+    <Or>
+      <Method name="toBoolean" />
+      <Method name="toBooleanObject" />
+    </Or>
     <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
   </Match>
+  <Match>
+    <Class name="org.apache.commons.lang3.BooleanUtils" />
+    <Method name="toBoolean" />
+    <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN" />
+  </Match>
+
+  <!-- Reason: Behavior documented in javadoc -->
+  <Match>
+    <Class name="org.apache.commons.lang3.BooleanUtils" />
+    <Or>
+      <Method name="negate" />
+      <Method name="toBooleanObject" />
+    </Or>
+    <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+  </Match>
+
+  <!-- Reason: base class cannot be changed and field is properly checked against null so behavior is OK -->
+  <Match>
+    <Class name="org.apache.commons.lang3.text.ExtendedMessageFormat" />
+    <Method name="applyPattern" />
+    <Bug pattern="UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR" />
+  </Match>
 
   <!-- Reason: Optimization to use == -->
   <Match>