You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Tomáš Procházka <ka...@razdva.cz> on 2021/03/21 16:23:08 UTC
Review of PRs
Hi,
I'd like to ask if somebody can review two PRs I prepared.
https://github.com/apache/netbeans/pull/2739
improves code completion of HTML forms,
https://github.com/apache/netbeans/pull/2772
makes PHP Annotation API public and without it I'm unable to add new
annotations for PHPStan: https://issues.apache.org/jira/browse/NETBEANS-5367
Regards,
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Review of PRs
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
The HTML Forms PR is a no brainer and excellent to have, new items, no
actual code changes, easy to approve and merge, so that’s what I did.
Gj
On Sun, 21 Mar 2021 at 17:23, Tomáš Procházka <ka...@razdva.cz> wrote:
> Hi,
> I'd like to ask if somebody can review two PRs I prepared.
>
> https://github.com/apache/netbeans/pull/2739
> improves code completion of HTML forms,
>
> https://github.com/apache/netbeans/pull/2772
> makes PHP Annotation API public and without it I'm unable to add new
> annotations for PHPStan:
> https://issues.apache.org/jira/browse/NETBEANS-5367
>
> Regards,
> Tom
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>