[GitHub] [spark] mridulm commented on pull request #29977: [SPARK-33088][CORE] Enhance ExecutorPlugin API to include callbacks on task start and end events

[GitBox <gi...@apache.org>]

mridulm commented on pull request #29977:
URL: https://github.com/apache/spark/pull/29977#issuecomment-705731860


   The changes mostly look good, thanks for working on it @fsamuel-bs !
   Given `TaskContext.get()` exposes a pretty much everything about the task which the plugin could require, we are in a pretty good shape.
   Do we want to include additional metadata to be passed in from driver for a subset of stage/task to the plugin ?
   Currently global info can be passed in via `init` and job properties can be used to pass in metadata; but wondering if we need something more fine grained ... thoughts ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org