[jira] Updated: (DERBY-3325) Add 'maxStatements' property to ClientConnectionPoolDataSource

["Kristian Waagan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3325:
-----------------------------------

    Attachment: derby-3325-1a-maxStatements.stat
                derby-3325-1a-maxStatements.diff

'derby-3325-1a-maxStatements.diff' introduces the maxStatements property for the ClientConnectionPoolDataSource. The property is specified in the JDBC 4.0 standard, chapter 11.8 (don't remember if it was introduced in an earlier revision).

Due to the current inheritance hierarchy, and the type being passed around in Derby, I have added the variable itself and the getter method to ClientBaseDataSource. They don't really belong there, but it was the easiest solution to avoid having to cast objects in the factory methods.
If people think we should "redesign" the hierarchy and/or change the factory method signatures, I'm open for suggestions and opinions. I know there has been an earlier effort towards the hierarchy, so I would have to read up on why things were changed before we change something again.

Only ClientPooledConnectionDataSource has a setter method. I have not added it to the XADataSource (I could not find any mention of statement pooling for XA in the standard, as I did for connection pooling).

Note that the included test is not yet enabled.

Patch ready for review.

> Add 'maxStatements' property to ClientConnectionPoolDataSource
> --------------------------------------------------------------
>
>                 Key: DERBY-3325
>                 URL: https://issues.apache.org/jira/browse/DERBY-3325
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3325-1a-maxStatements.diff, derby-3325-1a-maxStatements.stat
>
>
> The classes in Derby implementing javax.sql.ConnectionPoolDataSource must provide setter and getter methods for the property 'maxStatements'.
> This property is used to control the whether the data source should produce pooled connections with statement cache capabilities or not, and how big the statement cache is allowed to be.
> This issue only deals with the client JDBC driver.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.