You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "XiaokaiWang (Code Review)" <ge...@cloudera.org> on 2019/07/25 08:27:27 UTC
[kudu-CR] comment: delete the outdated comment
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13917
Change subject: comment: delete the outdated comment
......................................................................
comment: delete the outdated comment
Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
---
M src/kudu/consensus/time_manager.h
M src/kudu/tablet/mvcc.h
2 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/13917/1
--
To view, visit http://gerrit.cloudera.org:8080/13917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
Gerrit-Change-Number: 13917
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
[kudu-CR] comment: delete the outdated comment
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 )
Change subject: comment: delete the outdated comment
......................................................................
Patch Set 1: Code-Review+2
I couldn't find a document with this name anywhere in Kudu's commit history. Perhaps it's something David forgot to merge and has since been lost to time.
Andrew, does this ring any bells to you?
--
To view, visit http://gerrit.cloudera.org:8080/13917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
Gerrit-Change-Number: 13917
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:12:05 +0000
Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
Posted by "XiaokaiWang (Code Review)" <ge...@cloudera.org>.
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 )
Change subject: comment: delete the outdated comment
......................................................................
Patch Set 1:
The file 'repeatable-reads.md' is not exist now, I think it's necessary to delete the comments to avoid misleading readers.
--
To view, visit http://gerrit.cloudera.org:8080/13917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
Gerrit-Change-Number: 13917
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 08:33:02 +0000
Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 )
Change subject: comment: delete the outdated comment
......................................................................
Patch Set 1:
> > Patch Set 1: Code-Review+2
> >
> > I couldn't find a document with this name anywhere in Kudu's
> commit history. Perhaps it's something David forgot to merge and
> has since been lost to time.
> >
> > Andrew, does this ring any bells to you?
>
> It doesn't. My best guess is this may have pointed to
> https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations,
> which outlines transaction semantics with respect to scans.
> > Patch Set 1: Code-Review+2
> >
> > I couldn't find a document with this name anywhere in Kudu's
> commit history. Perhaps it's something David forgot to merge and
> has since been lost to time.
> >
> > Andrew, does this ring any bells to you?
>
> It doesn't. My best guess is this may have pointed to
> https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations,
> which outlines transaction semantics with respect to scans.
It seems the reference to docs/design-docs/repeatable-reads.md appeared in time_manager.h in the very first revision. Also, referencing transaction_semantics.adoc from mvcc.h mentions 'clean' time, which is not mentioned anywhere in the top-level of design docs (as I can see).
Most likely, it might be a document that David had in his local git workspace, but it hasn't been committed?
--
To view, visit http://gerrit.cloudera.org:8080/13917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
Gerrit-Change-Number: 13917
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 21:23:11 +0000
Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 )
Change subject: comment: delete the outdated comment
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> I couldn't find a document with this name anywhere in Kudu's commit history. Perhaps it's something David forgot to merge and has since been lost to time.
>
> Andrew, does this ring any bells to you?
It doesn't. My best guess is this may have pointed to https://github.com/apache/kudu/blob/37a81b82cc2e5e1ca9ad7291740b4e963e609bcc/docs/transaction_semantics.adoc#recommendations, which outlines transaction semantics with respect to scans.
--
To view, visit http://gerrit.cloudera.org:8080/13917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
Gerrit-Change-Number: 13917
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 21:18:58 +0000
Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13917 )
Change subject: comment: delete the outdated comment
......................................................................
comment: delete the outdated comment
Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
Reviewed-on: http://gerrit.cloudera.org:8080/13917
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/consensus/time_manager.h
M src/kudu/tablet/mvcc.h
2 files changed, 0 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5
Gerrit-Change-Number: 13917
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>