You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Geoff Hayman <gh...@jawbone.com> on 2012/09/17 23:27:28 UTC
Wicket 6 / Modal Dialogs and Safari
In Wicket 6 using Safari, a modal dialog will not allow interactions with
form components. The whole dialog always seems to be in "drag" mode. Click
anyw here on the panel and the dialog will drag.
Interaction works fine with all other browsers.
Safari interaction works fine with previous Wicket release.
Is this a known issue? I have a QuickStart if needed.
Thanks
Geoff
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066.html
Sent from the Users forum mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
Posted by Geoff Hayman <gh...@jawbone.com>.
https://issues.apache.org/jira/browse/WICKET-4770
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652120.html
Sent from the Users forum mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
Please create a ticket at http://issues.apache.org/jira/browse/WICKET
and attach the patch.
Thanks!
On Tue, Sep 18, 2012 at 4:13 AM, Geoff Hayman <gh...@jawbone.com> wrote:
> My apologies... the patch file was incomplete. This one supersedes the
> previous one
>
>
> http://apache-wicket.1842946.n4.nabble.com/file/n4652075/Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
> Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
>
>
>
> --
> View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652075.html
> Sent from the Users forum mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
Posted by Geoff Hayman <gh...@jawbone.com>.
My apologies... the patch file was incomplete. This one supersedes the
previous one
http://apache-wicket.1842946.n4.nabble.com/file/n4652075/Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652075.html
Sent from the Users forum mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
Posted by Geoff Hayman <gh...@jawbone.com>.
I have a proposed fix - please let me know if I've analyzed the problem
correctly.
The modal dialog tries to set event.ignore=true if the browser is Safari.
This Wicket event data structure used to be passed through to
Wicket.Drag.mouseDownHandler as the argument e. However, in the switch over
to jQuery events the argument (e) passed to mouseDownHandler is no longer
Wicket "event". It is now jQuery event data.
There is a test in mouseDownHandler to check for the existence of e.ignore.
As this is now jQuery data, it _never_ exists, so Safari is never
recognized.
I changed this test to check event.ignore and it appears to work correctly.
Patch file attached.
http://apache-wicket.1842946.n4.nabble.com/file/n4652074/Fix_to_Wicket_6___Safari_modal_window_drag_issue.patch
Fix_to_Wicket_6___Safari_modal_window_drag_issue.patch
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652074.html
Sent from the Users forum mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
Posted by Geoff Hayman <gh...@jawbone.com>.
This issue can also be seen here:
http://www.wicket-library.com/wicket-examples-6.0.x/ajax/modal-window
Using Safari, the dialog appears to resize rather that select input fields
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652068.html
Sent from the Users forum mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org