You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/20 06:39:31 UTC
[GitHub] [flink] twalthr commented on a change in pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables
twalthr commented on a change in pull request #11986:
URL: https://github.com/apache/flink/pull/11986#discussion_r427773573
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceITCase.java
##########
@@ -143,20 +149,19 @@ public void testProjectableJdbcSource() throws Exception {
")"
);
- StreamITCase.clear();
- tEnv.toAppendStream(tEnv.sqlQuery("SELECT timestamp6_col, decimal_col FROM " + INPUT_TABLE), Row.class)
- .addSink(new StreamITCase.StringSink<>());
- env.execute();
+ TableResult tableResult = tEnv.executeSql("SELECT timestamp6_col, decimal_col FROM " + INPUT_TABLE);
+
+ List<String> results = manifestResults(tableResult);
- List<String> expected =
- Arrays.asList(
- "2020-01-01T15:35:00.123456,100.1234",
- "2020-01-01T15:36:01.123456,101.1234");
- StreamITCase.compareWithList(expected);
+ assertThat(
+ results,
+ containsInAnyOrder(
+ "2020-01-01T15:35:00.123456,100.1234",
Review comment:
@aljoscha for the future: please use instances instead of strings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org