[GitHub] [incubator-superset] villebro commented on a change in pull request #9469: [mypy] Enforcing typing for superset.examples

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9469: [mypy] Enforcing typing for superset.examples
URL: https://github.com/apache/incubator-superset/pull/9469#discussion_r403666103
 
 

 ##########
 File path: superset/examples/multiformat_time_series.py
 ##########
 @@ -70,15 +73,15 @@ def load_multiformat_time_series(only_metadata=False, force=False):
         obj = TBL(table_name=tbl_name)
     obj.main_dttm_col = "ds"
     obj.database = database
-    dttm_and_expr_dict = {
-        "ds": [None, None],
-        "ds2": [None, None],
-        "epoch_s": ["epoch_s", None],
-        "epoch_ms": ["epoch_ms", None],
-        "string2": ["%Y%m%d-%H%M%S", None],
-        "string1": ["%Y-%m-%d^%H:%M:%S", None],
-        "string0": ["%Y-%m-%d %H:%M:%S.%f", None],
-        "string3": ["%Y/%m/%d%H:%M:%S.%f", None],
+    dttm_and_expr_dict: Dict[str, Tuple[Optional[str], None]] = {
+        "ds": (None, None),
+        "ds2": (None, None),
+        "epoch_s": ("epoch_s", None),
+        "epoch_ms": ("epoch_ms", None),
+        "string2": ("%Y%m%d-%H%M%S", None),
+        "string1": ("%Y-%m-%d^%H:%M:%S", None),
+        "string0": ("%Y-%m-%d %H:%M:%S.%f", None),
+        "string3": ("%Y/%m/%d%H:%M:%S.%f", None),
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org