[jira] [Work logged] (HIVE-21198) Introduce a database object reference class

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-21198?focusedWorklogId=339472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339472 ]

ASF GitHub Bot logged work on HIVE-21198:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Nov/19 16:43
            Start Date: 06/Nov/19 16:43
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #550: HIVE-21198 Introduce a database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r343202348
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/TruncateTableDesc.java
 ##########
 @@ -39,8 +39,7 @@
 public class TruncateTableDesc implements DDLDescWithWriteId, Serializable {
   private static final long serialVersionUID = 1L;
 
-  private final String tableName;
-  private final String fullTableName;
 
 Review comment:
   yeah...this seems to be one place where this tablename git confusing ... :+1: 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 339472)
    Time Spent: 2h 20m  (was: 2h 10m)

> Introduce a database object reference class
> -------------------------------------------
>
>                 Key: HIVE-21198
>                 URL: https://issues.apache.org/jira/browse/HIVE-21198
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: David Lavati
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21198.1.patch, HIVE-21198.10.patch, HIVE-21198.2.patch, HIVE-21198.3.patch, HIVE-21198.4.patch, HIVE-21198.5.patch, HIVE-21198.6.patch, HIVE-21198.7.patch, HIVE-21198.8.patch, HIVE-21198.9.patch
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a single string; there are some places where the they travel as 2 separate arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass these informations together. Making this better is required if we would be wanting to enable dot in tablenames 
> HIVE-16907, HIVE-21151



--
This message was sent by Atlassian Jira
(v8.3.4#803005)