You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/25 08:32:46 UTC
[GitHub] [airflow] parisni opened a new issue #19196: Allow to turn dag run state to skipped
parisni opened a new issue #19196:
URL: https://github.com/apache/airflow/issues/19196
### Description
Behing able to track failed task in the past run is great. Sometimes the task has failed but we don't care. To remove the entry from the failed task (because this is polluting), we only have the option to turn it to `success` witch is not the real semantic.
I would prefer to be able to turn it to `skipped`. This would help in the future if we change our mind about this particular failure. Also having it to `skipped` will help to remove this false positive read flags in the UI and improve productivity of the team.
### Use case/motivation
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-954408216
> @bbovenzi the purpose here is dag, not task level
If the only motivation for a new dagrun state is having a nicer filtering in the UI - I would say that this is a won't fix.
The description also sounds very specific to your case. I for example leave runs that "I don't care about" as failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] parisni edited a comment on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
parisni edited a comment on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-953644366
@bbovenzi the purpose here is dag, not task level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
eladkal closed issue #19196:
URL: https://github.com/apache/airflow/issues/19196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-953088016
Wait, do you want to mark a single task instance as `skipped` or the whole dag run? I'm not sure if that is a valid state for a dag run, but it is fairly easy to do for a task instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] parisni commented on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
parisni commented on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-953644366
@bbovenzi the purpose here is dag, not state level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mehmax commented on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
mehmax commented on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-953255967
Would it be sufficient to add a "Mark Skipped" to the TaskInstance view?:
e.g:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-953558714
A DAG run cannot be marked as skipped. A task instance can. I quickly checked and this is probably doable, I don't think there are special rules regarding skipped tasks that don't work if the state is set after the task starts running.
But to be honest, personally I don't feel "marking a completed task instance as skipped" is more semantic than setting it to success, because the task instance is pretty obviously not skipped. Maybe it's best to introduce something specific for this, like how unit test frameworks have distinct `xfail` and `skip` concepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-1067669683
Since no further comments on this I'm closing this request as wont fix.
We can revisit in the future if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #19196: Allow to turn dag run state to skipped
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #19196:
URL: https://github.com/apache/airflow/issues/19196#issuecomment-950664786
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org