svn commit: r539556 - /myfaces/core/branches/jsf12/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java

[ba...@apache.org]

Author: baranda
Date: Fri May 18 11:48:05 2007
New Revision: 539556

URL: http://svn.apache.org/viewvc?view=rev&rev=539556
Log:
Part of MYFACES-1633 (Incorret view rendering after postback)

Modified:
    myfaces/core/branches/jsf12/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java

Modified: myfaces/core/branches/jsf12/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/jsf12/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java?view=diff&rev=539556&r1=539555&r2=539556
==============================================================================
--- myfaces/core/branches/jsf12/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java (original)
+++ myfaces/core/branches/jsf12/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java Fri May 18 11:48:05 2007
@@ -68,7 +68,7 @@
     private String _jspId = null;
     private String _facesJspId = null;
 
-    private List<String> _childrenAdded = null;
+    private Set<String> _childrenAdded = null;
     private List<String> _facetsAdded = null;
 
     private UIComponent _componentInstance = null;
@@ -129,7 +129,11 @@
     }
 
      protected List<String> getCreatedComponents() {
-        return _childrenAdded;
+         if (_childrenAdded != null)
+         {
+            return new ArrayList<String>(_childrenAdded);
+         }
+         return null;
     }
     
     /**
@@ -173,13 +177,10 @@
     {
         if (_childrenAdded == null)
         {
-            _childrenAdded = new ArrayList<String>();
+            _childrenAdded = new HashSet<String>();
         }
 
-        if (!_childrenAdded.contains(child.getId()))
-        {
-            _childrenAdded.add(child.getId());
-        }
+        _childrenAdded.add(child.getId());
     }
 
     /**
@@ -895,7 +896,7 @@
      */
     private void removeFormerChildren(UIComponent component)
     {
-        List<String> formerChildIds = (List<String>)component.getAttributes().get(FORMER_CHILD_IDS_SET_ATTR);
+        Set<String> formerChildIds = (Set<String>)component.getAttributes().get(FORMER_CHILD_IDS_SET_ATTR);
         if (formerChildIds != null)
         {
             for (String childId : formerChildIds)
@@ -1270,7 +1271,7 @@
     {
         if (parentTag._childrenAdded == null)
         {
-            parentTag._childrenAdded = new ArrayList<String>();
+            parentTag._childrenAdded = new HashSet<String>();
         }
 
         if (!parentTag._childrenAdded.contains(id))
@@ -1288,7 +1289,7 @@
     /**
      * Utility method for creating diagnostic output.
      */
-    private String printList(List childrenAdded)
+    private String printList(Collection childrenAdded)
     {
         StringBuffer buf = new StringBuffer();