[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on code in PR #13312:
URL: https://github.com/apache/kafka/pull/13312#discussion_r1182456902


##########
clients/src/test/java/org/apache/kafka/common/utils/ByteUtilsTest.java:
##########
@@ -241,6 +244,119 @@ public void testDouble() throws IOException {
         assertDoubleSerde(Double.NEGATIVE_INFINITY, 0xFFF0000000000000L);
     }
 
+    @Test
+    public void testCorrectnessWriteUnsignedVarlong() {

Review Comment:
   I would be inclined to keep this test to catch any potential bugs in the future changes to the `WriteUnsignedVarlong` implementation. This test increases the testing coverage over a larger range of values than what the existing tests check for.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org