You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/11/24 17:48:53 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #266: HDDS-2627. Skip sonar check in forks

adoroszlai opened a new pull request #266: HDDS-2627. Skip sonar check in forks
URL: https://github.com/apache/hadoop-ozone/pull/266
 
 
   ## What changes were proposed in this pull request?
   
   HDDS-2587 added Sonar check in post-commit workflow, publishing results to SonarCloud.  It does not work in forks, as it requires SonarCloud token.  This causes _unit_ step to fail completely.  Example: https://github.com/bharatviswa504/hadoop-ozone/runs/316829850
   
   This PR proposes to skip the check for forks.  (Ideally it would be skipped if `SONARCLOUD_TOKEN` is not set, but I could not add a condition based on that.)
   
   https://issues.apache.org/jira/browse/HDDS-2627
   
   ## How was this patch tested?
   
   Pushed to own fork: [unit check passed, sonar step skipped](https://github.com/adoroszlai/hadoop-ozone/runs/318237775).
   
   It would be great if someone with write access to `apache/hadoop-ozone` could push the same to a "feature" branch and verify that Sonar check is executed as expected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org