You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/11 08:46:56 UTC

[GitHub] [beam] scwhittle commented on a change in pull request #13410: [BEAM-11327] Replace Charset.defaultCharset() with StandardCharsets.UTF_8

scwhittle commented on a change in pull request #13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r540782777



##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactory.java
##########
@@ -86,7 +86,7 @@ public void write(int i) throws IOException {
       this.logger = Logger.getLogger(loggerName);
       this.buffer = new StringBuilder();
       this.decoder =
-          Charset.defaultCharset()
+          StandardCharsets.UTF_8

Review comment:
       Sorry lost track of that comment, I believe it's only uses are for System.out/System.err and the test. But allowing the test to specify a specific charset so it passes reliably sounds like a good solution.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org