You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by bozdoz <gi...@git.apache.org> on 2017/07/08 00:12:03 UTC
[GitHub] cordova-plugin-file-transfer pull request #182: Fire successCallback for any...
GitHub user bozdoz opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/182
Fire successCallback for any 2XX HTTP status
Found this bug when receiving a 201 response.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bozdoz/cordova-plugin-file-transfer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit a7d3c876506a0d694294c97e16d9e6b10b160c7a
Author: Benjamin J DeLong <ho...@gmail.com>
Date: 2017-07-08T00:11:23Z
Fire successCallback for any 2XX HTTP status
Found this bug when receiving a 201 response.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request #182: Fire successCallback for any...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #182: Fire successCallback for any 2XX HT...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/182
Yes this is an important change.
I'm wondering how we can set up testing for these kinds of issues. Perhaps that's a wider question about how to test the browser implementations of plugins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org