[GitHub] [tvm] PragmaTwice opened a new pull request, #12241: [Relay][VM] Fix an ICHECK which never fails in ctor of VMFunction

[GitBox <gi...@apache.org>]

PragmaTwice opened a new pull request, #12241:
URL: https://github.com/apache/tvm/pull/12241

   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   
   https://github.com/apache/tvm/blob/dff5c975a082e6f15b556914a029541b63ff1280/include/tvm/runtime/vm/vm.h#L97
   
   Since the referenced parameter `params` and `param_device_indexes` is moved in the member initializer list, 
   the assertion `ICHECK_EQ(params.size(), param_device_indexes.size())` is equivalent to `ICHECK_EQ(0, 0)` that never fails,
   which makes the `ICHECK` meaningless.
   
   PTAL @ganler ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] kparzysz-quic merged pull request #12241: [Relay][VM] Fix an ICHECK which never fails in ctor of VMFunction

[GitBox <gi...@apache.org>]

kparzysz-quic merged PR #12241:
URL: https://github.com/apache/tvm/pull/12241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org