You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/10/22 18:48:00 UTC

[GitHub] spark pull request #21860: [SPARK-24901][SQL]Merge the codegen of RegularHas...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21860#discussion_r226981919
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ---
    @@ -744,6 +744,7 @@ case class HashAggregateExec(
         val unsafeRowKeys = unsafeRowKeyCode.value
         val unsafeRowBuffer = ctx.freshName("unsafeRowAggBuffer")
         val fastRowBuffer = ctx.freshName("fastAggBuffer")
    +    val updateAggBuffer = ctx.freshName("updateAggBuffer")
    --- End diff --
    
    `updatedAggBuffer`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org