You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by mfranklin <gi...@git.apache.org> on 2014/07/10 19:49:15 UTC
[GitHub] incubator-streams pull request: Streams 131
GitHub user mfranklin opened a pull request:
https://github.com/apache/incubator-streams/pull/52
Streams 131
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-streams STREAMS-131
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit a2e0bfc248525a80f6db21540b37c1ba2aa8d274
Author: mfranklin <mf...@apache.org>
Date: 2014-07-10T13:32:00Z
STREAMS-131 | Updated stop to cleanup tasks and shutdown handler
commit a5e60126847d40c079ac6d05dc5ece92f62607e9
Author: mfranklin <mf...@apache.org>
Date: 2014-07-10T13:52:46Z
STREAMS-131 | Added flag to shutdown to indicate if the JVM is shutting down
commit 78aa10f4f371b1b7aee1c4e21231956dad015268
Author: mfranklin <mf...@apache.org>
Date: 2014-07-10T14:47:29Z
STREAMS-131 | Closing connections
commit 0d1fc31a87d50fed37860667e34b5d0e1fff6b35
Author: mfranklin <mf...@apache.org>
Date: 2014-07-10T15:12:18Z
STREAMS-131 | Fixed bug in elasticsearch client manager close
commit b45256c3ab87ba385fdee5170528dcffabecac57
Author: mfranklin <mf...@apache.org>
Date: 2014-07-10T15:20:03Z
STREAMS-131 | Updated elasticsearch persist writer to close timer
commit 32bf3c3fa97473b0eea0e272fd67023eef0a0f65
Author: mfranklin <mf...@apache.org>
Date: 2014-07-10T17:00:07Z
STREAMS-131 | Updated mongo persist writer to close background flush task on cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 131
Posted by sieverssj <gi...@git.apache.org>.
Github user sieverssj commented on the pull request:
https://github.com/apache/incubator-streams/pull/52#issuecomment-48956611
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 131
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/52#discussion_r14898303
--- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java ---
@@ -105,8 +105,8 @@ public void run() {
}
} finally {
- this.processor.cleanUp();
this.isRunning.set(false);
+ this.processor.cleanUp();
--- End diff --
Why is cleanUp() moved to after isRunning.set(false)? I believe you are creating a race condition here. The ProcesssorTask should still be running while its cleaning up. That way the task cannot be put up for garbage collection while its cleaning up. In cleaning up, it could be emptying internal queues or closing connections. All things we want to guarantee happen. Has the implementation changed so that this i not the case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 131
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/52#discussion_r14898698
--- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java ---
@@ -105,8 +105,8 @@ public void run() {
}
} finally {
- this.processor.cleanUp();
this.isRunning.set(false);
+ this.processor.cleanUp();
--- End diff --
it was moved because the isRunning flag is used (in part) to determine whether or not to continue polling the provider for data. we should stop polling the provider for data before cleaning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 131
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---