You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "hrak (via GitHub)" <gi...@apache.org> on 2023/03/01 11:03:57 UTC
[GitHub] [cloudstack-kubernetes-provider] hrak opened a new pull request, #44: Update to Kubernetes 1.26.2 + Use Go 1.18
hrak opened a new pull request, #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44
This PR is a continuation of the work in #32 and contains the following changes:
- Use Go 1.18
- Update Kubernetes deps to 1.26.2
- Move the cloudstack-go dep to its new home in the apache org
I can provide a test container image if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.11 + Use Go 1.19
Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1505004907
Added a switch to klog v2 + updated PR for k8s 1.24.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.11 + Use Go 1.19
Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450369462
Updated PR to use Kubernetes v1.24.11 instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud merged pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.26.2 + Use Go 1.19
Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450281799
> If you have the time I would really appreciate if there is a version in between. For instance 1.24.
yeah i was afraid of that already, i suddenly realized that compiling this against 1.26 probably means losing compatibility with 1.24 and 1.25 which are still supported. I will get on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] RolphH commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
Posted by "RolphH (via GitHub)" <gi...@apache.org>.
RolphH commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1506845292
@rohityadavcloud can you help getting this one merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1506928795
> @davidjumani could you have a quick look and help merge it.
>
> @RolphH @hrak could you advise what testing you’ve done against any/various versions of CloudStack?
We are running this without any issues so far on Cloudstack 4.17. We have some more changes in the pipeline once this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1506914074
@davidjumani could you have a quick look and help merge it.
@RolphH @hrak could you advise what testing you’ve done against any/various versions of CloudStack?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.11 + Use Go 1.19
Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1494067532
Ship it? Or does anything else need to happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1508127314
> We are running this without any issues so far on Cloudstack 4.17. We have some more changes in the pipeline once this is merged.
Well, maybe i should clarify: The part that works is the loadbalancer/firewall rules part. Most of the logic surrounding instance metadata is broken ever since this was turned into and external cloud provider. `GetZone` assumes this is running inside kubelet and that hostname=instance hostname, but it isn't, since the provider runs in a pod, causing it to try to look up the instance based on the pod hostname:
```
I0414 07:08:41.827320 1 cloudstack.go:175] GetZone called from /go/src/github.com/apache/cloudstack-kubernetes-provider/cloudstack_instances.go#198
E0414 07:08:41.874064 1 node_controller.go:220] error syncing 'k8s-mgmt-cp-dev-02': failed to get instance metadata for node k8s-mgmt-cp-dev-02: could not find instance for retrieving the zone: No match found for cloud-controller-manager-789b9fb546-dg46l: &{Count:0 VirtualMachines:[]}, requeuing
```
Then there are issues with ProviderID, since the provider is currently called `external-cloudstack` and should probably be called `cloudstack`, so the [logic here](https://github.com/kubernetes/cloud-provider/blob/322c087411fe027de06291c6ad974ed7bcbf2eea/cloud.go#L114) matches the kubelet arguments `--cloud-provider=external --provider-id=cloudstack:///8411c37d-8d63-4920-8cb2-01fa512c3377` in the same way that this works for f.e. the Openstack CCM.
I am working on fixes for all these issues but i would really like to get this in first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.26.2 + Use Go 1.19
Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450156357
Please let me know if 1.26 i a bit too ambitious, i will gladly adapt for 1.24 or 1.25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #44: Update to Kubernetes 1.26.2 + Use Go 1.19
Posted by "joschi36 (via GitHub)" <gi...@apache.org>.
joschi36 commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1450260367
If you have the time I would really appreciate if there is a version in between. For instance 1.24.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #44:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1508288264
Thanks @RolphH @hrak I'll merge this based on your tests and feedback. Pl do followup with other changes you think we need for the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org