You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <B....@competence.biz> on 2008/04/17 08:54:32 UTC

1.5: svn status --depth=files shows directories

	Hi,

On a test environment I have the following layout

C:\projects  (Checkout from file:///f:/_repos/txt)
C:\projects\project1 (Checkout from https://..../...; marked as an
svn:external on c:\projects)
C:\projects\newproject (Checkout from https://.../....2/...; not marked
as svn:external yet)

When I run
# svn status --depth=files C:\projects
...
X project1
? newproject
...

But when I look in svn_types.h
/* D + its file children, but not subdirs.  Updates will pull in any
     files not already present, but not subdirectories. */
  svn_depth_files      =  1,

So as a user I would expect /not/ to see the subdirectories. (I did not
find a more high level authorative definition on the depths)


I know how the wc library uses the depth to optimize which entries files
to read (And I *really like* this optimization as a library user); but I
don't think the CLI users want to see directories if they asked for just
the files.


I think we should document this behavior or change it before releasing
1.5.

I'm afraid this result depends on behavior of the current working copy
library and might change with the new WC implementation in planning. And
as the depth support is new in 1.5 we can still fix it; but we must
support it until 2.0 if we don't.

	Bert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: 1.5: svn status --depth=files shows directories

Posted by "Rui, Guo" <ti...@mail.ustc.edu.cn>.
On Thu, Apr 17, 2008 at 10:54:32AM +0200, Bert Huijben wrote:
> 	Hi,
> 
> On a test environment I have the following layout
> 
> C:\projects  (Checkout from file:///f:/_repos/txt)
> C:\projects\project1 (Checkout from https://..../...; marked as an
> svn:external on c:\projects)
> C:\projects\newproject (Checkout from https://.../....2/...; not marked
> as svn:external yet)
> 
> When I run
> # svn status --depth=files C:\projects
> ...
> X project1
> ? newproject
> ...
> 
This bug also exists in the HEAD of trunk. The problem seems that all
unversioned items will get showed if the path is not excluded. The status test
case in depth_tests.py obviously does not cover this situation.

> But when I look in svn_types.h
> /* D + its file children, but not subdirs.  Updates will pull in any
>      files not already present, but not subdirectories. */
>   svn_depth_files      =  1,
> 
> So as a user I would expect /not/ to see the subdirectories. (I did not
> find a more high level authorative definition on the depths)
> 
> 
> I know how the wc library uses the depth to optimize which entries files
> to read (And I *really like* this optimization as a library user); but I
> don't think the CLI users want to see directories if they asked for just
> the files.
> 
> 
> I think we should document this behavior or change it before releasing
> 1.5.
> 
> I'm afraid this result depends on behavior of the current working copy
> library and might change with the new WC implementation in planning. And
> as the depth support is new in 1.5 we can still fix it; but we must
> support it until 2.0 if we don't.
> 
> 	Bert
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: 1.5: svn status --depth=files shows directories

Posted by David Glasser <gl...@davidglasser.net>.
OK, so let's be specific: the issue here is that 'svn status
--depth=files' shows unversioned and externals directories (though not
ordinarily versioned ones)?

That does seem like a bug.

--dave

On Thu, Apr 17, 2008 at 1:54 AM, Bert Huijben <B....@competence.biz> wrote:
>         Hi,
>
>  On a test environment I have the following layout
>
>  C:\projects  (Checkout from file:///f:/_repos/txt)
>  C:\projects\project1 (Checkout from https://..../...; marked as an
>  svn:external on c:\projects)
>  C:\projects\newproject (Checkout from https://.../....2/...; not marked
>  as svn:external yet)
>
>  When I run
>  # svn status --depth=files C:\projects
>  ...
>  X project1
>  ? newproject
>  ...
>
>  But when I look in svn_types.h
>  /* D + its file children, but not subdirs.  Updates will pull in any
>      files not already present, but not subdirectories. */
>   svn_depth_files      =  1,
>
>  So as a user I would expect /not/ to see the subdirectories. (I did not
>  find a more high level authorative definition on the depths)
>
>
>  I know how the wc library uses the depth to optimize which entries files
>  to read (And I *really like* this optimization as a library user); but I
>  don't think the CLI users want to see directories if they asked for just
>  the files.
>
>
>  I think we should document this behavior or change it before releasing
>  1.5.
>
>  I'm afraid this result depends on behavior of the current working copy
>  library and might change with the new WC implementation in planning. And
>  as the depth support is new in 1.5 we can still fix it; but we must
>  support it until 2.0 if we don't.
>
>         Bert
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>  For additional commands, e-mail: dev-help@subversion.tigris.org
>
>



-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org