[GitHub] [flink] ifndef-SleePy commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor

[GitBox <gi...@apache.org>]

ifndef-SleePy commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/9072#issuecomment-512397736
 
 
   Hi @azagrebin ,
   
   I'm following the unstable case https://issues.apache.org/jira/browse/FLINK-11631 which is relevant to this PR. 
   
   I guess you have taken over the old PR https://github.com/apache/flink/pull/7757. I have a concern same with @tillrohrmann , there are two different tracking ways of task lifecycle. One is `unregisterTaskAndNotifyFinalState` and `TaskSlotTable`, the other is `TaskCompletionTracker`.
   
   I think this PR could work well at the moment. I'm just afraid we might encounter some subtle corner cases in the future. Maybe we should unify these two lifecycle tracking ways. Or we could merge this PR first, then think about unification. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services