You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/08/14 00:26:30 UTC

Re: Review Request 13085: Add a method that stringifies an Option.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13085/#review25095
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp
<https://reviews.apache.org/r/13085/#comment49300>

    Hm.. what if we have an Option<string>::some("NONE"), then this looks identical for both cases, perhaps we should kill this?


- Ben Mahler


On July 30, 2013, 10:06 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13085/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 10:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp 2bb7290cc306a955311bec5c97199470a441fff9 
> 
> Diff: https://reviews.apache.org/r/13085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>