You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/01/11 16:01:51 UTC
Review Request 55430: Log Search: Calendar widget for setting the
time range is confusing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55430/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-19469
https://issues.apache.org/jira/browse/AMBARI-19469
Repository: ambari
Description
-------
The UI for setting the time range shows two months side by side. The week shown on the bottom row on the left and the week shown at the top row on the right show the same dates, so clicking on any date on the bottom row of the left calendar makes a selection on the right and vice versa. This is really confusing. The same dates should not be repeated in left and right.
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js 04798c6
Diff: https://reviews.apache.org/r/55430/diff/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
Re: Review Request 55430: Log Search: Calendar widget for setting the
time range is confusing
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55430/#review161256
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Jan. 11, 2017, 4:01 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55430/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 4:01 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19469
> https://issues.apache.org/jira/browse/AMBARI-19469
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The UI for setting the time range shows two months side by side. The week shown on the bottom row on the left and the week shown at the top row on the right show the same dates, so clicking on any date on the bottom row of the left calendar makes a selection on the right and vice versa. This is really confusing. The same dates should not be repeated in left and right.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js 04798c6
>
> Diff: https://reviews.apache.org/r/55430/diff/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 55430: Log Search: Calendar widget for setting the
time range is confusing
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55430/#review161254
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 11, 2017, 4:01 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55430/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 4:01 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19469
> https://issues.apache.org/jira/browse/AMBARI-19469
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The UI for setting the time range shows two months side by side. The week shown on the bottom row on the left and the week shown at the top row on the right show the same dates, so clicking on any date on the bottom row of the left calendar makes a selection on the right and vice versa. This is really confusing. The same dates should not be repeated in left and right.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js 04798c6
>
> Diff: https://reviews.apache.org/r/55430/diff/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>