[GitHub] [incubator-doris] imay commented on a change in pull request #1996: Limit the memory consumption of broker scan node

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1996: Limit the memory consumption of broker scan node
URL: https://github.com/apache/incubator-doris/pull/1996#discussion_r335806704
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
 ##########
 @@ -750,16 +750,18 @@ public void finishTransaction(long transactionId, Set<Long> errorReplicaIds) thr
     
     // check if there exists a load job before the endTransactionId have all finished
     // load job maybe started but could not know the affected table id, so that we not check by table
-    public boolean isPreviousTransactionsFinished(long endTransactionId, long dbId) {
+    public boolean isPreviousTransactionsFinished(long endTransactionId, long dbId, boolean printLog) {
 
 Review comment:
   I think it is not reasonable to add a parameter to control if it print log.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org