[GitHub] [tvm] leandron commented on a change in pull request #7917: allow libbacktrace to be used when cross compiling the runtime

[GitBox <gi...@apache.org>]

leandron commented on a change in pull request #7917:
URL: https://github.com/apache/tvm/pull/7917#discussion_r620130294



##########
File path: cmake/libs/Libbacktrace.cmake
##########
@@ -21,7 +21,16 @@ ExternalProject_Add(project_libbacktrace
   SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/libbacktrace
   BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/libbacktrace
   CONFIGURE_COMMAND "${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/libbacktrace/configure"
-                    "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace" --with-pic
+                    "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
+                    --with-pic
+                    "CC=${CMAKE_C_COMPILER}"
+                    "CFLAGS=${CMAKE_C_FLAGS}"
+                    "LDFLAGS=${CMAKE_EXE_LINKER_FLAGS}"
+                    "CPP=${CMAKE_C_COMPILER} -E"

Review comment:
       Maybe this should actually point to the CXX version?
   
   ```suggestion
                       "CPP=${CMAKE_CXX_COMPILER} -E"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org