You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sb...@apache.org on 2017/01/09 08:56:21 UTC

[1/2] ignite git commit: IgniteCacheQueryNodeRestartSelfTest: increased test timeout.

Repository: ignite
Updated Branches:
  refs/heads/ignite-3477 0e8cb0098 -> 124ee7f19


IgniteCacheQueryNodeRestartSelfTest: increased test timeout.


Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/d484a76d
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/d484a76d
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/d484a76d

Branch: refs/heads/ignite-3477
Commit: d484a76ddfaca502f3f3997d5a98cd1eb9d136f2
Parents: 0e8cb00
Author: sboikov <sb...@gridgain.com>
Authored: Mon Jan 9 11:42:39 2017 +0300
Committer: sboikov <sb...@gridgain.com>
Committed: Mon Jan 9 11:42:39 2017 +0300

----------------------------------------------------------------------
 .../internal/processors/cache/database/tree/BPlusTree.java       | 4 ++--
 .../distributed/near/IgniteCacheQueryNodeRestartSelfTest.java    | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ignite/blob/d484a76d/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/database/tree/BPlusTree.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/database/tree/BPlusTree.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/database/tree/BPlusTree.java
index 0e41307..28fcfd8 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/database/tree/BPlusTree.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/database/tree/BPlusTree.java
@@ -3560,8 +3560,8 @@ public abstract class BPlusTree<L, T extends L> extends DataStructure {
         @SuppressWarnings("unchecked")
         private boolean fillFromBuffer(ByteBuffer buf, BPlusIO<L> io, int startIdx, int cnt)
             throws IgniteCheckedException {
-            assert io.isLeaf();
-            assert cnt != 0: cnt; // We can not see empty pages (empty tree handled in init).
+            assert io.isLeaf() : io;
+            assert cnt != 0 : cnt; // We can not see empty pages (empty tree handled in init).
             assert startIdx >= 0 : startIdx;
             assert cnt >= startIdx;
 

http://git-wip-us.apache.org/repos/asf/ignite/blob/d484a76d/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryNodeRestartSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryNodeRestartSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryNodeRestartSelfTest.java
index 45a249d..01a3d3f 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryNodeRestartSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryNodeRestartSelfTest.java
@@ -66,7 +66,7 @@ public class IgniteCacheQueryNodeRestartSelfTest extends GridCacheAbstractSelfTe
 
     /** {@inheritDoc} */
     @Override protected long getTestTimeout() {
-        return 90 * 1000;
+        return 3 * 60 * 1000;
     }
 
     /** {@inheritDoc} */
@@ -194,7 +194,6 @@ public class IgniteCacheQueryNodeRestartSelfTest extends GridCacheAbstractSelfTe
 
         info("Queries stopped.");
 
-
         info("Awaiting rebalance events [restartCnt=" + restartCnt.get() + ']');
 
         boolean success = lsnr.awaitEvents(GRID_CNT * 2 * restartCnt.get(), 15000);


[2/2] ignite git commit: ServerImpl: check attribute for null.

Posted by sb...@apache.org.
ServerImpl: check attribute for null.


Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/124ee7f1
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/124ee7f1
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/124ee7f1

Branch: refs/heads/ignite-3477
Commit: 124ee7f19883e73e0fc7940d6fdbe216593fd505
Parents: d484a76
Author: sboikov <sb...@gridgain.com>
Authored: Mon Jan 9 11:56:22 2017 +0300
Committer: sboikov <sb...@gridgain.com>
Committed: Mon Jan 9 11:56:22 2017 +0300

----------------------------------------------------------------------
 .../apache/ignite/spi/discovery/tcp/ServerImpl.java | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ignite/blob/124ee7f1/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
index 66f1173..44159c6 100644
--- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
@@ -3685,8 +3685,8 @@ class ServerImpl extends TcpDiscoveryImpl {
                     return;
                 }
 
-                boolean locActiveOnStart = locNode.attribute(ATTR_ACTIVE_ON_START);
-                boolean rmtActiveOnStart = node.attribute(ATTR_ACTIVE_ON_START);
+                boolean locActiveOnStart = booleanAttribute(locNode, ATTR_ACTIVE_ON_START, true);
+                boolean rmtActiveOnStart = booleanAttribute(node, ATTR_ACTIVE_ON_START, true);
 
                 if (locActiveOnStart != rmtActiveOnStart) {
                     String errMsg = "Local node's active on start flag differs from " +
@@ -3801,6 +3801,18 @@ class ServerImpl extends TcpDiscoveryImpl {
         }
 
         /**
+         * @param node Node.
+         * @param name Attribute name.
+         * @param dflt Default value.
+         * @return Attribute value.
+         */
+        private boolean booleanAttribute(ClusterNode node, String name, boolean dflt) {
+            Boolean attr = node.attribute(name);
+
+            return attr != null ? attr : dflt;
+        }
+
+        /**
          * @param node Joining node.
          * @param errMsg Message to log.
          * @param sndMsg Message to send.