You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/05/23 20:09:39 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2108: upgrade helix-front from Angular 5.1 to 5.2
micahstubbs opened a new pull request, #2108:
URL: https://github.com/apache/helix/pull/2108
### Issues
#2053: Increment progress towards the goal of upgrading helix-front to the current version of Angular.
### Description
This PR upgrade helix-front from Angular 5.1 to 5.2.
### Tests
Let's test the upgrade from Angular 5.1 to Angular 5.2:
- [x] `npm install` works
- [x] `npm run build` works
- [x] `npm start` works
- [x] `npm run test` runs and passes
- [x] `npm run lint` runs and passes
Helix UI renders with 0 errors and 1 warning in the browser console. The warning is understandable since I did not specify the optional config necessary for the Piwik analytics library to work.
<img width="886" alt="Screen Shot 2022-05-02 at 3 58 18 PM" src="https://user-images.githubusercontent.com/2119400/166339821-6354ea8b-2cf9-472c-a2fc-2e40485248dd.png">
`npm run test` results
<img width="640" alt="Screen Shot 2022-05-02 at 4 00 50 PM" src="https://user-images.githubusercontent.com/2119400/166339972-26dcd8eb-056b-43c5-8a79-00d9345e39ce.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 merged pull request #2108: upgrade helix-front from Angular 5.1 to 5.2
Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2108:
URL: https://github.com/apache/helix/pull/2108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2108: upgrade helix-front from Angular 5.1 to 5.2
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2108:
URL: https://github.com/apache/helix/pull/2108#issuecomment-1138087502
- [x] )PR Testing requirements should already be satisfied: no changes were made to any of the Java modules, only helix-front which is written in TypeScript. Helix Front tests pass.
- [x] [PR Template](https://github.com/apache/helix/wiki/Pull-Request-Description-Template) requirements should be satisfied now. Changes:
- add Github issue to commit message.
- add N/A sections from PR template and explicitly say that they are N/A.
- [x] [PR Guidelines](https://github.com/apache/helix/wiki/Pull-Request-Guidelines) should also be satisfied now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2108: upgrade helix-front from Angular 5.1 to 5.2
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2108:
URL: https://github.com/apache/helix/pull/2108#issuecomment-1136275137
It looks like there are CI test failures unrelated to these UI changes:
> Error: Failures:
Error: TestWorkflowTimeout.testWorkflowPausedTimeout:79 ยป Helix Fail to stop the work...
Error:
> Error: Tests run: 1314, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 5,985.3 s <<< FAILURE! - in TestSuite
> Error: testClusterStatusMonitorLifecycle(org.apache.helix.monitoring.TestClusterStatusMonitorLifecycle) Time elapsed: 71.214 s <<< FAILURE!
[CI Test Run Logs](https://github.com/apache/helix/runs/6562239607?check_suite_focus=true)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] somecodemonkey commented on pull request #2108: upgrade helix-front from Angular 5.1 to 5.2
Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2108:
URL: https://github.com/apache/helix/pull/2108#issuecomment-1136199820
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2108: upgrade helix-front from Angular 5.1 to 5.2
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2108:
URL: https://github.com/apache/helix/pull/2108#issuecomment-1135093070
This PR is ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2108: upgrade helix-front from Angular 5.1 to 5.2
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2108:
URL: https://github.com/apache/helix/pull/2108#issuecomment-1135093792
@junkaixue here is the new PR with the clean commit history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2108: upgrade helix-front from Angular 5.1 to 5.2
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2108:
URL: https://github.com/apache/helix/pull/2108#issuecomment-1138087831
This PR is ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org