You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "joao-r-reis (via GitHub)" <gi...@apache.org> on 2025/06/03 12:14:02 UTC

Re: [PR] CASSGO-75: remove proto 1 and 2 support [cassandra-gocql-driver]

joao-r-reis commented on code in PR #1890:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1890#discussion_r2123627738


##########
marshal.go:
##########
@@ -113,10 +113,6 @@ type Unmarshaler interface {
 //
 // The marshal/unmarshal error provides a list of supported types when an unsupported type is attempted.
 func Marshal(info TypeInfo, value interface{}) ([]byte, error) {
-	if info.Version() < protoVersion1 {
-		panic("protocol version not set")
-	}

Review Comment:
   we probably want to keep this, IIUC it's checking if the field is set or left as empty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org