You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:45:49 UTC

[GitHub] [flink] XComp opened a new pull request #14579: [FLINK-20619]

XComp opened a new pull request #14579:
URL: https://github.com/apache/flink/pull/14579


   ## What is the purpose of the change
   
   This PR covers the removal of `InputDependencyConstraint` and `InputDependencyConstraintChecker`.
   
   This PR depends on PR #14578 covering [FLINK-20600](https://issues.apache.org/jira/browse/FLINK-20600) being merged.
   
   ## Brief change log
   
   Any usages of the two classes was removed.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     }, {
       "hash" : "074b504578f5186fac8940506ead72405223fccd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "074b504578f5186fac8940506ead72405223fccd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f56b38533cab0967f4c4adc4b8e48bd97ee73a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784) 
   * 03178ba20775c21969e53b91005a831f6d149623 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799) 
   * 074b504578f5186fac8940506ead72405223fccd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762) 
   * 1f56b38533cab0967f4c4adc4b8e48bd97ee73a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784) 
   * 03178ba20775c21969e53b91005a831f6d149623 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     }, {
       "hash" : "074b504578f5186fac8940506ead72405223fccd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802",
       "triggerID" : "074b504578f5186fac8940506ead72405223fccd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 074b504578f5186fac8940506ead72405223fccd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82b153a0647052d6f747d047d9f64336f2c88d8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750) 
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zhuzhurk edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
zhuzhurk edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756533725


   Thanks for opening this PR! @XComp 
   The change looks good to me except that a python test for InputDependencyConstraint was not removed and is causing test failure:
   "FAILED pyflink/common/tests/test_execution_config.py::ExecutionConfigTests::test_get_set_default_input_dependency_constraint"
   
   I think we can remove this failed test case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     }, {
       "hash" : "074b504578f5186fac8940506ead72405223fccd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "074b504578f5186fac8940506ead72405223fccd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762) 
   * 1f56b38533cab0967f4c4adc4b8e48bd97ee73a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784) 
   * 03178ba20775c21969e53b91005a831f6d149623 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799) 
   * 074b504578f5186fac8940506ead72405223fccd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     }, {
       "hash" : "074b504578f5186fac8940506ead72405223fccd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802",
       "triggerID" : "074b504578f5186fac8940506ead72405223fccd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63de094a42dfa2ee9674576465297bb907d63ea2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11821",
       "triggerID" : "63de094a42dfa2ee9674576465297bb907d63ea2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 074b504578f5186fac8940506ead72405223fccd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802) 
   * 63de094a42dfa2ee9674576465297bb907d63ea2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11821) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756533725


   There is a test failure in python module.
   "FAILED pyflink/common/tests/test_execution_config.py::ExecutionConfigTests::test_get_set_default_input_dependency_constraint"
   
   I think we can just remove this test case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     }, {
       "hash" : "074b504578f5186fac8940506ead72405223fccd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802",
       "triggerID" : "074b504578f5186fac8940506ead72405223fccd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63de094a42dfa2ee9674576465297bb907d63ea2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "63de094a42dfa2ee9674576465297bb907d63ea2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 074b504578f5186fac8940506ead72405223fccd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802) 
   * 63de094a42dfa2ee9674576465297bb907d63ea2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82b153a0647052d6f747d047d9f64336f2c88d8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XComp commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756604087


   Yeah, I realized it this morning that I had `*.java` set up as a filter in my Idea search dialog. 😇 I fixed it.
   
   But are we ok with just removing the public API as is? Or should we provide the skeleton methods not doing anything and labeling them as deprecated?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger closed pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #14579:
URL: https://github.com/apache/flink/pull/14579


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-757510492


   The commit to deprecate `InputDependencyConstraint` looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     }, {
       "hash" : "074b504578f5186fac8940506ead72405223fccd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802",
       "triggerID" : "074b504578f5186fac8940506ead72405223fccd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63de094a42dfa2ee9674576465297bb907d63ea2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11821",
       "triggerID" : "63de094a42dfa2ee9674576465297bb907d63ea2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 63de094a42dfa2ee9674576465297bb907d63ea2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11821) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82b153a0647052d6f747d047d9f64336f2c88d8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750) 
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-757962921


   The build failure seems unrelated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762) 
   * 1f56b38533cab0967f4c4adc4b8e48bd97ee73a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784) 
   * 03178ba20775c21969e53b91005a831f6d149623 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14579: [FLINK-20619]

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82b153a0647052d6f747d047d9f64336f2c88d8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762) 
   * 1f56b38533cab0967f4c4adc4b8e48bd97ee73a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756622002


   I think you are right. It would be better to annotate the  methods as `@Deprecated` first and remove it in future versions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762) 
   * 1f56b38533cab0967f4c4adc4b8e48bd97ee73a3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11784",
       "triggerID" : "1f56b38533cab0967f4c4adc4b8e48bd97ee73a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "03178ba20775c21969e53b91005a831f6d149623",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799",
       "triggerID" : "03178ba20775c21969e53b91005a831f6d149623",
       "triggerType" : "PUSH"
     }, {
       "hash" : "074b504578f5186fac8940506ead72405223fccd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802",
       "triggerID" : "074b504578f5186fac8940506ead72405223fccd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 03178ba20775c21969e53b91005a831f6d149623 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11799) 
   * 074b504578f5186fac8940506ead72405223fccd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11802) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756130759


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11750",
       "triggerID" : "d82b153a0647052d6f747d047d9f64336f2c88d8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762",
       "triggerID" : "7b160f223f76e9592f74ce0e4649052f2c6367d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b160f223f76e9592f74ce0e4649052f2c6367d4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11762) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zhuzhurk commented on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756622002


   I think you are right. It would be better to annotate the  methods as `@Deprecated` first and remove it in future versions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XComp commented on pull request #14579: [FLINK-20619]

Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756136259


   @zhuzhurk you might want to have a look at this PR as well. ...since you suggested the removal in [FLINK-20619](https://issues.apache.org/jira/browse/FLINK-20619).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14579: [FLINK-20619] Removed InputDependencyConstraint

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756126448


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 63de094a42dfa2ee9674576465297bb907d63ea2 (Fri May 28 07:04:18 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14579: [FLINK-20619]

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14579:
URL: https://github.com/apache/flink/pull/14579#issuecomment-756126448


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d82b153a0647052d6f747d047d9f64336f2c88d8 (Thu Jan 07 13:47:33 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org