You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Pascal Schumacher (JIRA)" <ji...@apache.org> on 2016/10/22 14:11:58 UTC

[jira] [Closed] (LANG-780) Add HashCodeBuilder.append(Enum value)

     [ https://issues.apache.org/jira/browse/LANG-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pascal Schumacher closed LANG-780.
----------------------------------
       Resolution: Won't Fix
    Fix Version/s:     (was: Review Patch)

After reading the discussion I'm closing this as "Won't Fix".

> Add HashCodeBuilder.append(Enum value)
> --------------------------------------
>
>                 Key: LANG-780
>                 URL: https://issues.apache.org/jira/browse/LANG-780
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.builder.*
>    Affects Versions: 2.5
>            Reporter: Alex Pokotilo
>         Attachments: LANG-780.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Since Enum's hashCode return different values between calls this can cause different values if enum appended to HashCodeBuilder 
> IMHO adding append for enum would be enough to solve this entirely
> {code:java}
> public org.apache.commons.lang.builder.HashCodeBuilder append(Enum value)
> {
>  append(value.name().hashCode());
>  return this;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)