You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/09 20:33:05 UTC

[GitHub] [airflow] Chen-Oliver opened a new pull request, #28813: Add worker service account for LocalKubernetesExecutor

Chen-Oliver opened a new pull request, #28813:
URL: https://github.com/apache/airflow/pull/28813

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of an existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
`HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"pods \"extract-57f0f8f6590045d59eb2d36ce2bacb53\" is forbidden: error looking up service account airflow/airflow-worker: serviceaccount \"airflow-worker\" not found","reason":"Forbidden","details":{"name":"extract-57f0f8f6590045d59eb2d36ce2bacb53","kind":"pods"},"code":403}`
`WARNING - ApiException when attempting to run task, re-queueing. Reason: 'Forbidden'. Message: pods "extract-57f0f8f6590045d59eb2d36ce2bacb53" is forbidden: error looking up service account airflow/airflow-worker: serviceaccount "airflow-worker" not found`

When using the `KubernetesExecutor` as part of `LocalKubernetesExecutor`, it will fail due to a missing worker service account. This PR fixes that issue. Have tested this fix on the latest helm chart version.

**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham merged pull request #28813: Add worker service account for LocalKubernetesExecutor

Posted by GitBox <gi...@apache.org>.

jedcunningham merged PR #28813:
URL: https://github.com/apache/airflow/pull/28813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #28813:
URL: https://github.com/apache/airflow/pull/28813#issuecomment-1378048558

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on PR #28813:
URL: https://github.com/apache/airflow/pull/28813#issuecomment-1378048972

   Thanks @Chen-Oliver! Congrats on your first commit 🎉


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on PR #28813:
URL: https://github.com/apache/airflow/pull/28813#issuecomment-1376313388

   Thanks @Chen-Oliver. Can you add some [test coverage for the various executor options here](https://github.com/apache/airflow/blob/3ececb2c79307bd943aad116d7b0b5933af8185a/tests/charts/test_worker.py#L746) as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #28813:
URL: https://github.com/apache/airflow/pull/28813#issuecomment-1376280579

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Chen-Oliver commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

Posted by GitBox <gi...@apache.org>.

Chen-Oliver commented on PR #28813:
URL: https://github.com/apache/airflow/pull/28813#issuecomment-1376488870

   > Thanks @Chen-Oliver. Can you add some [test coverage for the various executor options here](https://github.com/apache/airflow/blob/3ececb2c79307bd943aad116d7b0b5933af8185a/tests/charts/test_worker.py#L746) as well?
   
   I've added a simple test, hopefully it is sufficient :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #28813:
URL: https://github.com/apache/airflow/pull/28813#issuecomment-1377970719

   rebased to account for doc failure fixed in main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org