[jira] [Commented] (HIVE-14094) Remove unused function closeFs from Warehouse.java

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349934#comment-15349934 ] 

Hive QA commented on HIVE-14094:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12813399/HIVE-14094.000.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10268 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_12
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_13
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_vector_complex_all
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_vector_complex_join
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/267/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/267/console
Test logs: http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-267/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12813399 - PreCommit-HIVE-MASTER-Build

> Remove unused function closeFs from Warehouse.java
> --------------------------------------------------
>
>                 Key: HIVE-14094
>                 URL: https://issues.apache.org/jira/browse/HIVE-14094
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Trivial
>         Attachments: HIVE-14094.000.patch
>
>
> Remove unused function closeFs from Warehouse.java
> after HIVE-10922, no one will call Warehouse.closeFs. It will be good to delete this function to prevent people from using it. Normally closing FileSystem is not safe because most of the time FileSystem will be shared.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)