You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by bo...@apache.org on 2023/08/11 12:04:22 UTC

[impala] branch master updated: IMPALA-12359: Add missing package-info file used by HiveVersionInfo

This is an automated email from the ASF dual-hosted git repository.

boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new a95859be0 IMPALA-12359: Add missing package-info file used by HiveVersionInfo
a95859be0 is described below

commit a95859be0b3bb06207956285d7bc19cfd8acf1c1
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Thu Aug 10 12:11:33 2023 +0200

    IMPALA-12359: Add missing package-info file used by HiveVersionInfo
    
    We create a minimal-impala-hive-exec.jar based on Hive's hive-exec.jar:
    https://github.com/apache/impala/blob/master/java/shaded-deps/hive-exec/pom.xml#L34
    
    This excludes lots of class files, including
    org/apache/hive/common/package-info.class that is used by
    HiveVersionAnnotation and HiveVersionInfo classes.
    
    Because of this HiveVersionInfo returns "Unknown" version resulting
    in failing Iceberg operations.
    
    Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
    Reviewed-on: http://gerrit.cloudera.org:8080/20340
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 java/shaded-deps/hive-exec/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/shaded-deps/hive-exec/pom.xml b/java/shaded-deps/hive-exec/pom.xml
index d509fdf8a..2ae440552 100644
--- a/java/shaded-deps/hive-exec/pom.xml
+++ b/java/shaded-deps/hive-exec/pom.xml
@@ -101,6 +101,7 @@ the same dependencies
                 <include>org/apache/hadoop/hive/ql/exec/vector/expressions/**/*</include>
                 <include>org/apache/hive/common/HiveVersionAnnotation.class</include>
                 <include>org/apache/hive/common/HiveCompat*</include>
+                <include>org/apache/hive/common/package-info.class</include>
                 <include>org/apache/hive/common/util/**</include>
                 <include>org/apache/hive/service/rpc/thrift/**</include>
                 <include>org/apache/hadoop/hive/serde/**</include>
@@ -109,7 +110,6 @@ the same dependencies
                 <include>org/apache/hadoop/hive/ql/plan/ColStatistics.class</include>
                 <include>org/apache/hadoop/hive/ql/stats/estimator/**</include>
                 <include>org/apache/hive/service/rpc/thrift/**</include>
-                <include>org/apache/hive/common/HiveVersionAnnotation.class</include>
                 <include>org/apache/hadoop/hive/ql/ErrorMsg.class</include>
                 <include>com/google/**</include>
                 <include>com/esri/**</include>