[GitHub] [bookkeeper] ivankelly commented on a change in pull request #2099: [DLOG] Delete empty inprogress segment on recovery

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #2099: [DLOG] Delete empty inprogress segment on recovery
URL: https://github.com/apache/bookkeeper/pull/2099#discussion_r285741594
 
 

 ##########
 File path: stream/distributedlog/core/src/test/java/org/apache/distributedlog/TestDistributedLogBase.java
 ##########
 @@ -95,15 +95,16 @@
     protected static String zkServers;
     protected static int zkPort;
     protected static int numBookies = 3;
-    private static final List<File> tmpDirs = new ArrayList<File>();
+    protected static final List<File> TMP_DIRS = new ArrayList<File>();
 
     @BeforeClass
     public static void setupCluster() throws Exception {
         File zkTmpDir = IOUtils.createTempDir("zookeeper", "distrlog");
-        tmpDirs.add(zkTmpDir);
+        TMP_DIRS.add(zkTmpDir);
         Pair<ZooKeeperServerShim, Integer> serverAndPort = LocalDLMEmulator.runZookeeperOnAnyPort(zkTmpDir);
         zks = serverAndPort.getLeft();
         zkPort = serverAndPort.getRight();
+        LOG.info("IKDEBUG num bookies is {}", numBookies);
 
 Review comment:
   oops, will remove

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services