You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Will Johnson (JIRA)" <ji...@apache.org> on 2007/05/14 22:19:16 UTC

[jira] Created: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Read IndexSchema from InputStream instead of Config file
--------------------------------------------------------

                 Key: SOLR-239
                 URL: https://issues.apache.org/jira/browse/SOLR-239
             Project: Solr
          Issue Type: Improvement
    Affects Versions: 1.2
         Environment: all
            Reporter: Will Johnson
            Priority: Minor
             Fix For: 1.2


Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-239:
------------------------------

    Attachment: IndexSchemaStream2.patch

patch updated.  now with the added benefit of compiling.

> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-239:
------------------------------

    Attachment: IndexSchemaStream2.patch

new patch that includes a GetFile servlet to possibly replace get-file.jsp due to the fact that it writes out invalid xml.  

> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500704 ] 

Will Johnson commented on SOLR-239:
-----------------------------------

after seeing that i'd need to regenerate a patch for the new IndexSchema's SolrException handling i got to thinking about ways to preserve the getInputStream() functionality.  tracing things down a bit it seems to all fall to Config.openResource(fileName).  i was wondering if it might not be better to extend that code to handle URL's as well as file names by looking for http:// at the beginning of the resourceName.  this might open up other avenues for centralized configuration of all of solr in the future but it does at least solve this problem and maintain more backwards compatibility with the existing api.  

thoughts?


> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-239:
------------------------------

    Attachment: IndexSchemaStream2.patch

the attached patch (IndexSchemaStream2.patch) includes a cleaned up test case as well as making the IndexSchema constructors throw a SolrException since they are reading InputStreams (which they were before).  i think perhaps they should throw something a big 'stronger' but that seemed to have more wide-reaching implications.


> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas closed SOLR-239.
---------------------------

    Resolution: Incomplete

Comments indicate that this is no longer being pursued.

> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505846 ] 

Will Johnson commented on SOLR-239:
-----------------------------------

after looking at all the dependencies for IndexSchema and with the addition of the new solrj stuff in trunk i no longer think this approach is the correct way to go about things.  the LukeRequest/LukeResponse seems to give most of the same info with ~0 overhead and it's already checked in.  

> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-239:
------------------------------

    Attachment: IndexSchemaStream.patch

patch with test cases attached.  i also had to change raw-schema.jsp to be a redirect to get-files.jsp however it wasn't clear that raw-schema.jsp was in use anymore.

> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-239:
------------------------------

    Attachment: IndexSchemaStream2.patch

New patch that address all 6 suggestions.  The one thing that is interesting is that using http://localhost:8983/solr/admin/get-file.jsp?file=schema.xml does not work as it prints out a number of newlines before the XML declaration which causes it to be invalid.  I'm not quite sure how to fix this without rewriting get-file.jsp as a servlet and making sure it only prints out the xml.

In any case it does work against url's that only contain valid xml however I wasn't sure how we go about testing things that require the example to be running. (the test is therefore commented out)

as for motivations, yes it does require a good bit of overhead and i think it would be good to have a 'lighter' IndexSchema implementation for client api's.   i do think however that it's nice to know exactly what is running and to be able to inspect each fields capabilities so i'm not sure what the right thing to do is.

- will


> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496606 ] 

Otis Gospodnetic commented on SOLR-239:
---------------------------------------

Minor comment: if you use the same name for the patch file, JIRA will automatically gray out the older one, thus making it easier to spot which patches are out of date, and which one is the fresh one to look at.

Thanks for the patch, this sounds useful.


> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-239:
------------------------------

    Attachment: IndexSchemaStream2.patch

updated with fixed and test raw-schema.jsp and added back the IndexSchema testDynamicCopy() test.



> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500888 ] 

Hoss Man commented on SOLR-239:
-------------------------------

FWIW: I really don't think preserving getIputStream() is really necessary, but as a public method it shouldn't' be removed without discussion.

Thinking about this whole issue a little bit more now, am i correct in understanding that your original goal was to allow clients to parse a remote schema as an InputStream (fetched from the server via a URL).

i have to question whether it really makes sense for clients to use the IndexSchema class ... it requires a lot of baggage (like all of the field types and all of the analyzers) that are probably overkill for most clients, and break the abstraction solr provides where clients only need to know about fields names, and the server takes care of the rest.  A simple DOM model of hte schema.xml seems like it would really solve 99.9999% of the problems clients might need.

But for the purposes of this discussion let's focus on the other 0.0001% of the problems...

Making Config.openResource(String) support URLs might be a little overkill for achieving the immediate goal, and it seems like it would raise a lot more questions then it may solve.

Why not just add an IndexSchema(URL) constructor...

 * add new private URL schemaUrl
 * add new IndexSchema(URL) constructor that sets schemaUrl and calls readConfig()
 * modify getInputStream to return Config.openResource(schemaFile) only if it's not null, otherwise return URL.openStream()

(this doesn't preclude or make more complex any possible future decision to allow Config.openResource to support URLs) 

while we're at it we should probably...
 * change the private readConfig to take an InputStream as a param
   * modify the constructors that call readConfig to pass an explict InputStream made from their input
 * deprecate public getInputStream()


> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by Will Johnson <wj...@GETCONNECTED.COM>.
i'll have another go at the patch tomorrow morning; testing the raw-schema.jsp (even if it's not used) and put back the test.
 
- will

________________________________

From: Chris Hostetter [mailto:hossman_lucene@fucit.org]
Sent: Thu 5/24/2007 6:02 PM
To: solr-dev@lucene.apache.org
Subject: RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file




: 2) why did you remove testDynamicCopy() from IndexSchemaTest ?
:
: becuase it had nothing to do with testing the index schema.  as far as i
: could tell it was a ctrl-c / ctrl-v error.  that or i'm really blind and
: happy to put it back.

idon't see a test with that name defined anywhere.  it's testing that you
can declare dynamic fields and copy them using copyField ... that sounds
like an IndexSchemaTest to me  (lots of other schema related tests may be
in BasicFunctionalityTest or ConvertedLegacyTest, but we should try to use
the class specific test classes when the test is very narrow)

: 3) raw-schema.jsp on the trunk appears to be completely broken (multiple
: <%@ page contentType="..."%> declarations), and not linked to from the

: my patch worked but i also saw that it wasn't linked anywhere.

i thought your patch left the multiple contentType declarations, but i
don't rememebr for certain now ... it's a trivial issue either way.




-Hoss




RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by Chris Hostetter <ho...@fucit.org>.
: 2) why did you remove testDynamicCopy() from IndexSchemaTest ?
:
: becuase it had nothing to do with testing the index schema.  as far as i
: could tell it was a ctrl-c / ctrl-v error.  that or i'm really blind and
: happy to put it back.

idon't see a test with that name defined anywhere.  it's testing that you
can declare dynamic fields and copy them using copyField ... that sounds
like an IndexSchemaTest to me  (lots of other schema related tests may be
in BasicFunctionalityTest or ConvertedLegacyTest, but we should try to use
the class specific test classes when the test is very narrow)

: 3) raw-schema.jsp on the trunk appears to be completely broken (multiple
: <%@ page contentType="..."%> declarations), and not linked to from the

: my patch worked but i also saw that it wasn't linked anywhere.

i thought your patch left the multiple contentType declarations, but i
don't rememebr for certain now ... it's a trivial issue either way.




-Hoss


RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by Will Johnson <wj...@GETCONNECTED.COM>.
1) there is a public API change here by removing the getIputStream() method from IndexSearcher.  probably not a big deal but important that we consider it.

true, that called wasn't used anywhere else in the solr trunk code.  also after a lot of thought i realized that it's in general a poor idea to rely on getting an input stream in any reliable fashion other than when it's first opened.  (many don't support reset)  i can put it back easily if people are that worried about breaking compatibility but in general it seems like it's asking for trouble without knowing the implemntation.

2) why did you remove testDynamicCopy() from IndexSchemaTest ?

becuase it had nothing to do with testing the index schema.  as far as i could tell it was a ctrl-c / ctrl-v error.  that or i'm really blind and happy to put it back.

3) raw-schema.jsp on the trunk appears to be completely broken (multiple <%@ page contentType="..."%> declarations), and not linked to from the admin screen anyway ... we might want to just remove it completely and make a note in the CHANGES in case people have the old URL bookmarked.

my patch worked but i also saw that it wasn't linked anywhere.
 
- will
 

> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by. 

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498840 ] 

Hoss Man commented on SOLR-239:
-------------------------------

a few notes from skimming the patch...

1) there is a public API change here by removing the getIputStream() method from IndexSearcher.  probably not a big deal but important that we consider it.

2) why did you remove testDynamicCopy() from IndexSchemaTest ?

3) raw-schema.jsp on the trunk appears to be completely broken (multiple <%@ page contentType="..."%> declarations), and not linked to from the admin screen anyway ... we might want to just remove it completely and make a note in the CHANGES in case people have the old URL bookmarked.

> Read IndexSchema from InputStream instead of Config file
> --------------------------------------------------------
>
>                 Key: SOLR-239
>                 URL: https://issues.apache.org/jira/browse/SOLR-239
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, IndexSchemaStream2.patch
>
>
> Soon to follow patch adds a constructor to IndexSchema to allow them to be created directly from InputStreams.  The overall logic for the Core's use of the IndexSchema creation/use does not change however this allows java clients like those in SOLR-20 to be able to parse an IndexSchema.  Once a schema is parsed, the client can inspect an index's capabilities which is useful for building generic search UI's.  ie provide a drop down list of fields to search/sort by.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.