You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2009/12/15 00:09:18 UTC
[jira] Created: (HBASE-2044) HBASE-1822 removed not-deprecated APIs
HBASE-1822 removed not-deprecated APIs
--------------------------------------
Key: HBASE-2044
URL: https://issues.apache.org/jira/browse/HBASE-2044
Project: Hadoop HBase
Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Fix For: 0.21.0
The scope of HBASE-1822 was to remove deprecated APIs but some methods removed weren't even deprecated in the first place. For example from Scan:
{code}
-
- /**
- * Parses a combined family and qualifier and adds either both or just the
- * family in case there is not qualifier. This assumes the older colon
- * divided notation, e.g. "data:contents" or "meta:".
- * <p>
- * Note: It will through an error when the colon is missing.
- *
- * @param familyAndQualifier
- * @return A reference to this instance.
- * @throws IllegalArgumentException When the colon is missing.
- */
- public Scan addColumn(byte[] familyAndQualifier) {
- byte [][] fq = KeyValue.parseColumn(familyAndQualifier);
- if (fq.length > 1 && fq[1] != null && fq[1].length > 0) {
- addColumn(fq[0], fq[1]);
- } else {
- addFamily(fq[0]);
- }
- return this;
- }
{code}
There's more than 1 method and the same applies for Get. Also o.a.h.h.io.Cell was cleaned but not removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2044) HBASE-1822 removed not-deprecated
APIs
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-2044.
---------------------------------------
Resolution: Fixed
Committed to trunk.
> HBASE-1822 removed not-deprecated APIs
> --------------------------------------
>
> Key: HBASE-2044
> URL: https://issues.apache.org/jira/browse/HBASE-2044
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.21.0
>
> Attachments: HBASE-2044.patch
>
>
> The scope of HBASE-1822 was to remove deprecated APIs but some methods removed weren't even deprecated in the first place. For example from Scan:
> {code}
> -
> - /**
> - * Parses a combined family and qualifier and adds either both or just the
> - * family in case there is not qualifier. This assumes the older colon
> - * divided notation, e.g. "data:contents" or "meta:".
> - * <p>
> - * Note: It will through an error when the colon is missing.
> - *
> - * @param familyAndQualifier
> - * @return A reference to this instance.
> - * @throws IllegalArgumentException When the colon is missing.
> - */
> - public Scan addColumn(byte[] familyAndQualifier) {
> - byte [][] fq = KeyValue.parseColumn(familyAndQualifier);
> - if (fq.length > 1 && fq[1] != null && fq[1].length > 0) {
> - addColumn(fq[0], fq[1]);
> - } else {
> - addFamily(fq[0]);
> - }
> - return this;
> - }
> {code}
> There's more than 1 method and the same applies for Get. Also o.a.h.h.io.Cell was cleaned but not removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2044) HBASE-1822 removed not-deprecated APIs
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-2044:
--------------------------------------
Attachment: HBASE-2044.patch
Putting back in place deleted methods with @deprecated this time, we will have to remove those in 0.22
I didn't add the methods back in Result since Cell was itself deprecated.
I'm also deleting the empty Cell.java file.
> HBASE-1822 removed not-deprecated APIs
> --------------------------------------
>
> Key: HBASE-2044
> URL: https://issues.apache.org/jira/browse/HBASE-2044
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.21.0
>
> Attachments: HBASE-2044.patch
>
>
> The scope of HBASE-1822 was to remove deprecated APIs but some methods removed weren't even deprecated in the first place. For example from Scan:
> {code}
> -
> - /**
> - * Parses a combined family and qualifier and adds either both or just the
> - * family in case there is not qualifier. This assumes the older colon
> - * divided notation, e.g. "data:contents" or "meta:".
> - * <p>
> - * Note: It will through an error when the colon is missing.
> - *
> - * @param familyAndQualifier
> - * @return A reference to this instance.
> - * @throws IllegalArgumentException When the colon is missing.
> - */
> - public Scan addColumn(byte[] familyAndQualifier) {
> - byte [][] fq = KeyValue.parseColumn(familyAndQualifier);
> - if (fq.length > 1 && fq[1] != null && fq[1].length > 0) {
> - addColumn(fq[0], fq[1]);
> - } else {
> - addFamily(fq[0]);
> - }
> - return this;
> - }
> {code}
> There's more than 1 method and the same applies for Get. Also o.a.h.h.io.Cell was cleaned but not removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2044) HBASE-1822 removed not-deprecated
APIs
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790438#action_12790438 ]
stack commented on HBASE-2044:
------------------------------
we do not want that method? it should have been deprecated but we want to move away from colon delimited family and qualifier?
> HBASE-1822 removed not-deprecated APIs
> --------------------------------------
>
> Key: HBASE-2044
> URL: https://issues.apache.org/jira/browse/HBASE-2044
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.21.0
>
>
> The scope of HBASE-1822 was to remove deprecated APIs but some methods removed weren't even deprecated in the first place. For example from Scan:
> {code}
> -
> - /**
> - * Parses a combined family and qualifier and adds either both or just the
> - * family in case there is not qualifier. This assumes the older colon
> - * divided notation, e.g. "data:contents" or "meta:".
> - * <p>
> - * Note: It will through an error when the colon is missing.
> - *
> - * @param familyAndQualifier
> - * @return A reference to this instance.
> - * @throws IllegalArgumentException When the colon is missing.
> - */
> - public Scan addColumn(byte[] familyAndQualifier) {
> - byte [][] fq = KeyValue.parseColumn(familyAndQualifier);
> - if (fq.length > 1 && fq[1] != null && fq[1].length > 0) {
> - addColumn(fq[0], fq[1]);
> - } else {
> - addFamily(fq[0]);
> - }
> - return this;
> - }
> {code}
> There's more than 1 method and the same applies for Get. Also o.a.h.h.io.Cell was cleaned but not removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.