You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by snoopdave <gi...@git.apache.org> on 2015/04/18 00:29:16 UTC
[GitHub] incubator-usergrid pull request: Ensure that when external token v...
GitHub user snoopdave opened a pull request:
https://github.com/apache/incubator-usergrid/pull/230
Ensure that when external token validation is enabled, Admin Users cannot sign-up
Or be activated or be confirmed... all that should happen via Usergrid Central.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-usergrid USERGRID-575
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 11709e05cc74abcadde0f817734ef04562237b41
Author: Dave Johnson <dm...@apigee.com>
Date: 2015-04-17T22:23:00Z
Ensure that when external token validation is enabled, Admin Users cannot be created, activated or confirmed; plus a test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Ensure that when external token v...
Posted by GERey <gi...@git.apache.org>.
Github user GERey commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/230#issuecomment-94494557
Just for future reference, issue is detailed here https://issues.apache.org/jira/browse/USERGRID-575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Ensure that when external token v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-usergrid/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Ensure that when external token v...
Posted by GERey <gi...@git.apache.org>.
Github user GERey commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/230#issuecomment-94494416
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Ensure that when external token v...
Posted by GERey <gi...@git.apache.org>.
Github user GERey commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/230#discussion_r28635118
--- Diff: stack/rest/src/main/java/org/apache/usergrid/rest/management/users/UserResource.java ---
@@ -355,6 +389,14 @@ public JSONWithPadding reactivate( @Context UriInfo ui,
@QueryParam( "callback" ) @DefaultValue( "callback" ) String callback )
throws Exception {
+ final boolean externalTokensEnabled =
+ !StringUtils.isEmpty( properties.getProperty( ManagementResource.USERGRID_CENTRAL_URL ) );
+
+ if ( externalTokensEnabled ) {
+ throw new IllegalArgumentException( "Admin Users must reactiveate via " +
--- End diff --
typo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---