You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by AlBevi <gi...@git.apache.org> on 2014/11/04 14:12:14 UTC
[GitHub] cordova-plugin-file-transfer pull request: CRC downloaded files ov...
GitHub user AlBevi opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/47
CRC downloaded files over 3G not match
Some cell providers compress files, my case Vodafone(Spain)
As a result we have doubly compressed files whose crc does not match the source file.
I've seen two solutions:
1. use https instead of http
2. Use non-transform
For me, it is me with option 2.
The idea is to add a no-transform cache-control HTTP header to request.
This disallow the server from making this kind of change.
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.9.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlBevi/cordova-plugin-file-transfer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 0bf9d996e11372143a9d86e6c9db9d1e84cfdcb7
Author: Alberto Benavente <al...@gmail.com>
Date: 2014-11-04T10:47:31Z
Update FileTransfer.java
commit 9b7b675f3dcfe467f3a729c9763d1258b504d75a
Author: Alberto Benavente <al...@gmail.com>
Date: 2014-11-04T12:52:14Z
Update CDVFileTransfer.m
commit 7ecc73352ebe4acc0bc9ef2f5af3d9ac70b34587
Author: Alberto Benavente <al...@gmail.com>
Date: 2014-11-04T12:53:03Z
Update CDVFileTransfer.m
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CRC downloaded files ov...
Posted by AlBevi <gi...@git.apache.org>.
Github user AlBevi commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/47#issuecomment-61657741
Good point. Honestly not read! :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CRC downloaded files ov...
Posted by AlBevi <gi...@git.apache.org>.
Github user AlBevi closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CRC downloaded files ov...
Posted by jpuerto <gi...@git.apache.org>.
Github user jpuerto commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/47#issuecomment-61642252
If you want to add this headers, why can't you add this headers directly when you made the request?
See: https://github.com/apache/cordova-plugin-file-transfer/blob/master/doc/index.md#download
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org