You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/20 22:30:35 UTC
[PR] [SPARK-58921][CONNECT][PYTHON] Fix misspelled messageParameters argument in Spark Connect tag validation [spark]
uros-b opened a new pull request, #58180:
URL: https://github.com/apache/spark/pull/58180
### What changes were proposed in this pull request?
Fixes a misspelled keyword argument in a `PySparkValueError` raised by the Spark Connect Python client. In `python/pyspark/sql/connect/client/core.py`, the error for a `None` tag was constructed with `message_paramters=` instead of `messageParameters=`.
### Why are the changes needed?
`PySparkValueError.__init__` (`pyspark/errors/exceptions/base.py`) accepts `messageParameters` and does not accept `**kwargs`. As a result, when the tag validation hits the `None` case it raises `TypeError: __init__() got an unexpected keyword argument 'message_paramters'` instead of the intended `CANNOT_BE_NONE` error. This is a latent bug on the error path.
### Does this PR introduce _any_ user-facing change?
Yes. Passing `None` where a Spark Connect tag is required now raises the intended `PySparkValueError` (`CANNOT_BE_NONE`) with its message, instead of a confusing `TypeError`.
### How was this patch tested?
The keyword is corrected to match the `PySparkValueError` constructor parameter. The affected path was previously unexercised, which is why the typo went unnoticed; I can add a regression test asserting `PySparkValueError` is raised for a `None` tag if preferred.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58921][CONNECT][PYTHON] Fix misspelled messageParameters argument in Spark Connect tag validation [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58180:
URL: https://github.com/apache/spark/pull/58180#issuecomment-5366463602
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/29f50bd5107f0910db9831293cc826c2d1c7d93e
- merged into branch-4.x https://github.com/apache/spark/commit/14c884c0ae04bace8fe9f1543cb34180f4c31d64
- merged into branch-4.3 https://github.com/apache/spark/commit/7367a2765ccaf8e1febea0de3830a8299713a963
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58921][CONNECT][PYTHON] Fix misspelled messageParameters argument in Spark Connect tag validation [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #58180: [SPARK-58921][CONNECT][PYTHON] Fix misspelled messageParameters argument in Spark Connect tag validation
URL: https://github.com/apache/spark/pull/58180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org