You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/08/30 11:49:22 UTC

[jira] Created: (HARMONY-1345) [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly

[classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-1345
                 URL: http://issues.apache.org/jira/browse/HARMONY-1345
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Richard Liang


Hello,

java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly. And method getNextWarning acts differently from RI when the chain has an object which is an instance of SQLException(which is added by the setNextException method)but not a SQLWaring.

I will attach a patch to fix this issue.

Best regards,
Richard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-1345) [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1345?page=all ]

Paulex Yang reassigned HARMONY-1345:
------------------------------------

    Assignee: Paulex Yang

> [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1345
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1345
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Richard Liang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1345.zip
>
>
> Hello,
> java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly. And method getNextWarning acts differently from RI when the chain has an object which is an instance of SQLException(which is added by the setNextException method)but not a SQLWaring.
> I will attach a patch to fix this issue.
> Best regards,
> Richard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-1345) [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1345?page=all ]

Paulex Yang closed HARMONY-1345.
--------------------------------


Verified by Richard.

> [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1345
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1345
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Richard Liang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1345.zip
>
>
> Hello,
> java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly. And method getNextWarning acts differently from RI when the chain has an object which is an instance of SQLException(which is added by the setNextException method)but not a SQLWaring.
> I will attach a patch to fix this issue.
> Best regards,
> Richard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-1345) [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1345?page=all ]

Paulex Yang resolved HARMONY-1345.
----------------------------------

    Resolution: Fixed

Richard, patch applied at revision r438803, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.

BTW, I noticed this patch includes serialization test for SQLWarning, it's fine, but my concern is this enhancement is irrevelant with and is not included in this JIRA/patch description, and I'm not sure if they are included by your intention, so I think it would be better if you separate them to another issue.

> [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1345
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1345
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Richard Liang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1345.zip
>
>
> Hello,
> java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly. And method getNextWarning acts differently from RI when the chain has an object which is an instance of SQLException(which is added by the setNextException method)but not a SQLWaring.
> I will attach a patch to fix this issue.
> Best regards,
> Richard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1345) [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1345?page=all ]

Richard Liang updated HARMONY-1345:
-----------------------------------

    Attachment: Harmony-1345.zip

Hello,

Would you please try this patch? Thanks a lot.

Best regards,
Richard

> [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1345
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1345
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Richard Liang
>         Attachments: Harmony-1345.zip
>
>
> Hello,
> java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly. And method getNextWarning acts differently from RI when the chain has an object which is an instance of SQLException(which is added by the setNextException method)but not a SQLWaring.
> I will attach a patch to fix this issue.
> Best regards,
> Richard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-1345) [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-1345?page=comments#action_12432407 ] 
            
Richard Liang commented on HARMONY-1345:
----------------------------------------

Hello Paulex,

Yes. I included the serialization test to verify the behavior of get/setNextWarning.

Best regards,
Richard.

> [classlib][sql] java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1345
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1345
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Richard Liang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1345.zip
>
>
> Hello,
> java.sql.SQLWarning#setNextWarning(SQLWarning ex) should add the SQLWarning ex to the end of the SQLWarning chain rather than replacing the next exception directly. And method getNextWarning acts differently from RI when the chain has an object which is an instance of SQLException(which is added by the setNextException method)but not a SQLWaring.
> I will attach a patch to fix this issue.
> Best regards,
> Richard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira