You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by risdenk <gi...@git.apache.org> on 2016/10/28 06:09:48 UTC
[GitHub] lucene-solr pull request #104: Jira/solr 8593
GitHub user risdenk opened a pull request:
https://github.com/apache/lucene-solr/pull/104
Jira/solr 8593
Creating this PR just so I can leave a few comments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/lucene-solr jira/solr-8593
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit b08a463639efe11b62be67324d638f572c7d668e
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-28T15:34:13Z
First commit for Calcite SQLHandler integration
commit c074b290591e0830e0f3da688c1133cb1a76afb3
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-28T16:07:46Z
Fix missing dependency and minor changes
commit 9425555405905d046367207333cae096c40d9bb2
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-28T19:14:51Z
Fix tests based on Calcite differences
commit 01a21000ab7c27d14178f6507a5ca71507eb7b97
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-28T19:52:44Z
More test fixes. Enabled all tests to run
commit e554ae404c7f9b1e452bfd01ba692a9b2f3fa4ae
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-28T20:08:22Z
Fix license location and CloudSolrClient leak
commit 52cc4d16bfe60c3aca8a8f4f48d5241b6be7bbb2
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-29T01:21:20Z
Fix JDBC tests, update dependencies, integrate Calcite more
commit e9ff7264ed8c135bf121c622a323d007c0205547
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-29T13:12:26Z
Minor fixes for CalciteSolrDriver and SQLHandler
commit 201527a611848ca19505bc44d61be98a11d51c4b
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-29T13:57:02Z
Fix JdbcTest for database metadata
commit a16ffc43ff7fed0477897319633caf807ea4cfeb
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-29T14:27:30Z
Fix avg(int) in tests
commit b31ea98bfaecd03d8996e3ccfd03afc3303df614
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-29T19:33:16Z
Misc cleanup trying to get a handle on rules
commit 1bd2e82477cfeeaa286b4fa92537b9cf7c90940c
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-29T21:12:00Z
Cleanup and fix NOT parsing issue. found new issue in pushdown
commit 1520ff3810050f70ad7175dd8f19ca1748279485
Author: Kevin Risden <kr...@apache.org>
Date: 2016-04-30T14:31:40Z
Cleanup SQLHandler to use JDBCStream if not requiring metadata
commit 10194585877e4926f4da0abf4ea2ae818b8191b8
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-02T18:52:18Z
Cleanup Calcite versions
commit d3f0700c9ba456168029312623a55341b3eca080
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-04T14:45:55Z
Cleanup rules. New rules broke some tests
commit 9e6f0b7a24bc3686d1823a3ab3577b3379d81b4a
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-04T16:15:17Z
Merge branch 'master' into jira/solr-8593
commit a414d246842837b99596e4b575afc73117df5e31
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-04T16:18:05Z
Fix sorts when grouping
commit 5daf6c40d8d796d0012fd6aa05c25548c9aef3c1
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-04T19:56:23Z
Cleanup implementation
commit 5d2994dfbf5cb13c1cdb2b52985eca3056b72074
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-04T22:10:37Z
Updated rules
commit 4ea7f4ef9b2f093aaf8032436aa58be020789ba3
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-04T22:21:54Z
Merge branch 'master' into jira/solr-8593
commit aae6f2703fb8436a5f71b85a8afd96c2383cec89
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-05T13:37:42Z
Merge branch 'master' into jira/solr-8593
commit 983ebba65d045fb02dcd4458473e62685a79bb88
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-05T15:24:35Z
Switch to CloudSolrClient builder
commit 3b28ec056faebc4b04f9dddc9f70d68c692901d4
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-05T15:24:57Z
Improve group by aggregates
commit d5d478e116c0d3745e5a04ff8b7b9754d62ee656
Author: Kevin Risden <kr...@apache.org>
Date: 2016-05-05T21:08:52Z
Disable a few rules
commit 2e7f5f9283519d8aefd31e241b9307ff61d72173
Author: Kevin Risden <kr...@apache.org>
Date: 2016-10-20T19:24:16Z
Merge branch 'apache-https-master' into jira/solr-8593
commit 285bbf0127384a14e1ebe98a017647cdb7fcfed8
Author: Kevin Risden <kr...@apache.org>
Date: 2016-10-27T20:08:30Z
Fix metadata handling
commit 1cd8da9863c31efe52c54e908f477aea7a9d9fa4
Author: Kevin Risden <kr...@apache.org>
Date: 2016-10-27T20:08:46Z
Merge branch 'apache-https-master' into jira/solr-8593
commit 6e4924cbfc828506550fd27b0350e3f12c572746
Author: Kevin Risden <kr...@apache.org>
Date: 2016-10-27T20:54:58Z
Update dependencies and fix minor errors
commit 77d33fa7472762fcfba928f76065ec05923f0acd
Author: Kevin Risden <kr...@apache.org>
Date: 2016-10-27T21:16:54Z
enable docvalues for a few fields
commit 34d889f25597bd4404eef96dedc2418f325f6925
Author: Kevin Risden <kr...@apache.org>
Date: 2016-10-27T21:17:10Z
Fix metadata handling
commit 8d04e2bc88f46df5c0fe5c4b7653709b7ab8a3c5
Author: Kevin Risden <kr...@apache.org>
Date: 2016-10-27T21:17:23Z
Fix test issues
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by joel-bernstein <gi...@git.apache.org>.
Github user joel-bernstein commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r92718063
--- Diff: solr/solrj/src/java/org/apache/solr/client/solrj/io/ops/GreaterThanOperation.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.io.ops;
+
+import java.io.IOException;
+import java.util.UUID;
+
+import org.apache.solr.client.solrj.io.Tuple;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation.ExpressionType;
+import org.apache.solr.client.solrj.io.stream.expr.StreamExpression;
+import org.apache.solr.client.solrj.io.stream.expr.StreamFactory;
+
+public class GreaterThanOperation extends LeafOperation {
+
+ private static final long serialVersionUID = 1;
+ private UUID operationNodeId = UUID.randomUUID();
+
+ public void operate(Tuple tuple) {
+ this.tuple = tuple;
+ }
+
+ public GreaterThanOperation(String field, double val) {
--- End diff --
This is the implementation Tuple.getDouble():
public Double getDouble(Object key) {
Object o = this.fields.get(key);
if(o == null) {
return null;
}
if(o instanceof Double) {
return (Double)o;
} else {
//Attempt to parse the double
return Double.parseDouble(o.toString());
}
}
So, any number will be translated to a double for comparison. We can implement a String comparison in a different operation I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85477051
--- Diff: solr/core/src/java/org/apache/solr/handler/sql/LimitStream.java ---
@@ -0,0 +1,89 @@
+/*
--- End diff --
Not sure this class is even necessary...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85477095
--- Diff: solr/core/src/java/org/apache/solr/handler/SQLHandler.java ---
@@ -126,30 +101,46 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
throw new Exception("stmt parameter cannot be null");
}
- context.setSolrClientCache(StreamHandler.clientCache);
+ String url = "jdbc:calcitesolr:";
+
+ Properties properties = new Properties();
+ // Add all query parameters
+ Iterator<String> parameterNamesIterator = params.getParameterNamesIterator();
+ while(parameterNamesIterator.hasNext()) {
+ String param = parameterNamesIterator.next();
+ properties.setProperty(param, params.get(param));
+ }
+
+ // Set these last to ensure that they are set properly
+ properties.setProperty("lex", Lex.MYSQL.toString());
+ properties.setProperty("zk", defaultZkhost);
+
+ String driverClass = CalciteSolrDriver.class.getCanonicalName();
+
+ // JDBC driver requires metadata from the SQLHandler. Default to false since this adds a new Metadata stream.
+ if(params.getBool("includeMetadata", false)) {
+ /*
+ * Would be great to replace this with the JDBCStream. Can't do that currently since need to have metadata
+ * added to the stream for the JDBC driver. This could be fixed by using the Calcite Avatica server and client.
+ */
+ tupleStream = new SqlHandlerStream(url, sql, properties, driverClass);
--- End diff --
Would be awesome to use JDBCStream in SqlHandlerStream...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476907
--- Diff: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/JDBCStream.java ---
@@ -223,7 +223,7 @@ public void open() throws IOException {
for(int columnIdx = 0; columnIdx < metadata.getColumnCount(); ++columnIdx){
final int columnNumber = columnIdx + 1; // cause it starts at 1
- final String columnName = metadata.getColumnName(columnNumber);
+ final String columnName = metadata.getColumnLabel(columnNumber);
--- End diff --
This makes sure to use the `AS` value instead of just the original column name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476713
--- Diff: lucene/ivy-versions.properties ---
@@ -99,6 +98,13 @@ io.netty.netty-all.version = 4.0.36.Final
/org.apache.ant/ant = 1.8.2
/org.apache.avro/avro = 1.7.5
+
+org.apache.calcite.version = 1.10.0
--- End diff --
Need 1.11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476724
--- Diff: lucene/ivy-versions.properties ---
@@ -99,6 +98,13 @@ io.netty.netty-all.version = 4.0.36.Final
/org.apache.ant/ant = 1.8.2
/org.apache.avro/avro = 1.7.5
+
+org.apache.calcite.version = 1.10.0
+org.apache.calcite.avatica.version = 1.9.0-SNAPSHOT
--- End diff --
Need 1.9.0 final
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476827
--- Diff: solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/JDBCStreamTest.java ---
@@ -354,8 +354,8 @@ public void testJDBCSolrInnerJoinExpressionWithProperties() throws Exception{
+ " rating_f as rating"
+ " ),"
+ " select("
- + " jdbc(connection=\"jdbc:hsqldb:mem:.\", sql=\"select PEOPLE.ID as PERSONID, PEOPLE.NAME, COUNTRIES.COUNTRY_NAME from PEOPLE inner join COUNTRIES on PEOPLE.COUNTRY_CODE = COUNTRIES.CODE order by PEOPLE.ID\", sort=\"ID asc\", get_column_name=true),"
- + " ID as personId,"
+ + " jdbc(connection=\"jdbc:hsqldb:mem:.\", sql=\"select PEOPLE.ID as PERSONID, PEOPLE.NAME, COUNTRIES.COUNTRY_NAME from PEOPLE inner join COUNTRIES on PEOPLE.COUNTRY_CODE = COUNTRIES.CODE order by PEOPLE.ID\", sort=\"PERSONID asc\", get_column_name=true),"
--- End diff --
Need to fix comment a few lines up from here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
Filter is needed for the Lucene query parsing piece. The rules aren't completely correct. Some issues with `is not` and others that need to add some tests for. It does compile though and able to do things like `select * ...`. I'm thinking back out a few of the rules to make this simpler then incrementally add from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r97372920
--- Diff: lucene/ivy-versions.properties ---
@@ -36,7 +34,7 @@ com.google.inject.guice.version = 3.0
/com.google.inject.extensions/guice-servlet = ${com.google.inject.guice.version}
/com.google.inject/guice = ${com.google.inject.guice.version}
-/com.google.protobuf/protobuf-java = 2.5.0
+/com.google.protobuf/protobuf-java = 3.1.0
--- End diff --
@markrmiller Can this be updated with the Hadoop support? Tests seem to pass but not sure if this affects protobuf compatibility with a running cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
https://github.com/apache/lucene-solr/tree/jira/solr-8593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by joel-bernstein <gi...@git.apache.org>.
Github user joel-bernstein commented on the issue:
https://github.com/apache/lucene-solr/pull/104
Hi Kevin,
Shall we push a branch out to apache/lucene-solr for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
@joel-bernstein if you push to the `jira/solr-8593` branch it should update this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476962
--- Diff: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ---
@@ -80,228 +70,24 @@ private void delete() throws Exception {
@Test
public void doTest() throws Exception {
waitForRecoveriesToFinish(false);
- testPredicate();
testBasicSelect();
--- End diff --
Need to enable all the tests again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
This is on `apache/lucene-solr` already. It is branch `jira/solr-8593`. I opened the PR just so I could comment on some of the files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476784
--- Diff: solr/core/src/java/org/apache/solr/handler/SQLHandler.java ---
@@ -126,30 +101,46 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
throw new Exception("stmt parameter cannot be null");
}
- context.setSolrClientCache(StreamHandler.clientCache);
+ String url = "jdbc:calcitesolr:";
--- End diff --
Need to use constant in driver.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476761
--- Diff: solr/core/src/java/org/apache/calcite/config/CalciteConnectionProperty.java ---
@@ -0,0 +1,182 @@
+/*
--- End diff --
This whole files needs to be removed when Calcite upgrades to Avatica 1.9 and releases 1.11 most likely
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476652
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -32,6 +32,7 @@
<caches lockStrategy="${ivy.lock-strategy}" resolutionCacheDir="${ivy.resolution-cache.dir}" />
<resolvers>
+ <ibiblio name="apache-snapshot" root="https://repository.apache.org/content/repositories/snapshots" m2compatible="true" />
--- End diff --
Need to remove when Avatica 1.9 and Calcite 1.11 is released
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85965892
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -32,6 +32,7 @@
<caches lockStrategy="${ivy.lock-strategy}" resolutionCacheDir="${ivy.resolution-cache.dir}" />
<resolvers>
+ <ibiblio name="apache-snapshot" root="https://repository.apache.org/content/repositories/snapshots" m2compatible="true" />
--- End diff --
Avatica 1.9 released and PR updated. Waiting on Calcite 1.11.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r92703928
--- Diff: solr/solrj/src/java/org/apache/solr/client/solrj/io/ops/GreaterThanOperation.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.io.ops;
+
+import java.io.IOException;
+import java.util.UUID;
+
+import org.apache.solr.client.solrj.io.Tuple;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation.ExpressionType;
+import org.apache.solr.client.solrj.io.stream.expr.StreamExpression;
+import org.apache.solr.client.solrj.io.stream.expr.StreamFactory;
+
+public class GreaterThanOperation extends LeafOperation {
+
+ private static final long serialVersionUID = 1;
+ private UUID operationNodeId = UUID.randomUUID();
+
+ public void operate(Tuple tuple) {
+ this.tuple = tuple;
+ }
+
+ public GreaterThanOperation(String field, double val) {
--- End diff --
@joel-bernstein - Does this mean that string/int/long comparisons won't work? I noticed that this assumes the fields are doubles.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476697
--- Diff: lucene/ivy-versions.properties ---
@@ -36,7 +34,7 @@ com.google.inject.guice.version = 3.0
/com.google.inject.extensions/guice-servlet = ${com.google.inject.guice.version}
/com.google.inject/guice = ${com.google.inject.guice.version}
-/com.google.protobuf/protobuf-java = 2.5.0
+/com.google.protobuf/protobuf-java = 3.1.0
--- End diff --
Can this be updated? Needed for Calcite/Avatica.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: SOLR-8593 - WIP
Posted by joel-bernstein <gi...@git.apache.org>.
Github user joel-bernstein commented on the issue:
https://github.com/apache/lucene-solr/pull/104
Ok, got it. I'll pull the branch and start working with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
@joel-bernstein FYI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476668
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -50,6 +51,7 @@
<resolver ref="local"/>
<!-- <resolver ref="local-maven-2" /> -->
<resolver ref="main"/>
+ <resolver ref="apache-snapshot" />
--- End diff --
Need to remove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org